[Backport 4.4.x] [Fixes #1893] Changing settings of a 3D Tiles resource throws an error

[dsuren1]

Description

This PR modifies the update process for the 3D Tiles subtype resource

Issue

• Changing settings of a 3D Tiles resource throws an error #1893

[gemini-code-assist]

Summary of Changes

Hello @dsuren1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an error that occurred when attempting to change the settings of 3D Tiles resources. The core change involves enhancing the resource update mechanism to intelligently differentiate between various resource subtypes. By introducing a new generic resource update API and implementing conditional logic, the system now correctly dispatches updates to the appropriate backend endpoint, ensuring that specialized resources like 3D Tiles can be configured without errors.

Highlights

• New API Endpoint for Resource Updates: A new updateResource API function has been introduced in geonode_mapstore_client/client/js/api/geonode/v2/index.js. This function allows for generic partial updates (PATCH requests) to resources based on their primary key.
• Conditional Resource Update Logic: The gnsave.js epic has been modified to dynamically select the appropriate update function for ResourceTypes.DATASET. It now checks if a resource's subtype is a default dataset subtype using isDefaultDatasetSubtype and calls either updateDataset or the new updateResourceAPI accordingly.
• Fix for 3D Tiles Resource Settings: This change specifically addresses an error encountered when modifying settings for 3D Tiles resources by ensuring that the correct API endpoint (updateResourceAPI) is invoked for non-default dataset subtypes, resolving the issue described in Changing settings of a 3D Tiles resource throws an error #1893.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue with updating 3D Tiles resources by introducing a generic updateResource API function and adapting the save logic to use it for non-default dataset subtypes. The implementation appears correct and follows existing patterns. My main feedback is the lack of unit tests for the new code paths. I've added specific comments on where tests should be added to ensure the new functionality is robust and to prevent future regressions.