Skip to content

[Backport 4.4.x] [Fixes #1893] Changing settings of a 3D Tiles resource throws an error #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allyoucanmap merged 2 commits into from
Nov 10, 2025
Merged

[Backport 4.4.x] [Fixes #1893] Changing settings of a 3D Tiles resource throws an error #2200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fed91d6
#1893 - Fix: Changing settings of a 3D Tiles resource throws an error
dsuren1 Oct 31, 2025
70cfce6
code refactor
dsuren1 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion geonode_mapstore_client/client/js/api/geonode/v2/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,11 @@ export const updateDocument = (pk, body) => {
.then(({ data }) => data.document);
};

export const updateResource = (pk, body) => {
return axios.patch(parseDevHostname(`${endpoints[RESOURCES]}/${pk}`), body)
.then(({ data }) => data.resource);
};

export const getUsers = ({
q,
page = 1,
Expand Down Expand Up @@ -967,5 +972,6 @@ export default {
deleteExecutionRequest,
getResourceByTypeAndByPk,
getFacetItems,
getFacetItemsByFacetName
getFacetItemsByFacetName,
updateResource
};
8 changes: 6 additions & 2 deletions geonode_mapstore_client/client/js/epics/gnsave.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ import {
updateDocument,
setMapThumbnail,
updateCompactPermissionsByPk,
getResourceByUuid
getResourceByUuid,
updateResource as updateResourceAPI
} from '@js/api/geonode/v2';
import { parseDevHostname } from '@js/utils/APIUtils';
import uuid from 'uuid';
Expand All @@ -72,6 +73,7 @@ import {
import {
ResourceTypes,
cleanCompactPermissions,
isDefaultDatasetSubtype,
toGeoNodeMapConfig
} from '@js/utils/ResourceUtils';
import {
Expand Down Expand Up @@ -119,7 +121,9 @@ const SaveAPI = {
return id ? updateDocument(id, body) : false;
},
[ResourceTypes.DATASET]: (state, id, body) => {
return id ? updateDataset(id, body) : false;
const currentResource = getResourceData(state);
const request = isDefaultDatasetSubtype(currentResource?.subtype) ? updateDataset : updateResourceAPI;
return id ? request(id, body) : false;
},
[ResourceTypes.VIEWER]: (state, id, body) => {
const user = userSelector(state);
Expand Down