fix(ErrorMessage): add component name in log message

include/geode/inspector/criterion/adjacency/brep_meshes_adjacency.hpp

@@ -45,11 +45,11 @@ namespace geode
     {
         InspectionIssuesMap< PolygonEdge >
             surfaces_edges_with_wrong_adjacencies{
-                "BRep Surface mesh with polygon edges adjacencies issues"
+                "polygon edges adjacencies"
             };
         InspectionIssuesMap< PolyhedronFacet >
             blocks_facets_with_wrong_adjacencies{
-                "BRep Block mesh with polyhedron facets adjacencies issues"
+                "polyhedron facets adjacencies"
             };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/adjacency/section_meshes_adjacency.hpp

@@ -45,7 +45,7 @@ namespace geode
     {
         InspectionIssuesMap< PolygonEdge >
             surfaces_edges_with_wrong_adjacencies{
-                "Section Surface mesh polygon edges adjacencies issues"
+                "polygon edges adjacencies"
             };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/colocation/component_meshes_colocation.hpp

@@ -41,7 +41,7 @@ namespace geode
     struct opengeode_inspector_inspector_api MeshesColocationInspectionResult
     {
         InspectionIssuesMap< std::vector< index_t > > colocated_points_groups{
-            "Model component meshes with colocated points"
+            "colocated points"
         };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/colocation/unique_vertices_colocation.hpp

@@ -39,12 +39,9 @@ namespace geode
     struct opengeode_inspector_inspector_api UniqueVerticesInspectionResult
     {
         InspectionIssues< std::vector< index_t > >
-            colocated_unique_vertices_groups{
-                "Model unique vertices which are colocated"
-            };
+            colocated_unique_vertices_groups{ "colocated unique vertices" };
         InspectionIssues< index_t > unique_vertices_linked_to_different_points{
-            "Model unique vertices linked to component mesh vertices at "
-            "different positions"
+            "unique vertex refering multiple positions"
         };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/degeneration/brep_meshes_degeneration.hpp

@@ -41,14 +41,12 @@ namespace geode
     struct
         opengeode_inspector_inspector_api BRepMeshesDegenerationInspectionResult
     {
-        InspectionIssuesMap< index_t > degenerated_edges{
-            "BRep component meshes with degenerated edges"
-        };
+        InspectionIssuesMap< index_t > degenerated_edges{ "degenerated edges" };
         InspectionIssuesMap< index_t > degenerated_polygons{
-            "BRep component meshes with degenerated polygons"
+            "degenerated polygons"
         };
         InspectionIssuesMap< index_t > degenerated_polyhedra{
-            "BRep component meshes with degenerated polyhedra"
+            "degenerated polyhedra"
         };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/degeneration/section_meshes_degeneration.hpp

@@ -41,11 +41,9 @@ namespace geode
     struct
         opengeode_inspector_inspector_api SectionMeshesDegenerationInspectionResult
     {
-        InspectionIssuesMap< index_t > degenerated_edges{
-            "Section component meshes with degenerated edges"
-        };
+        InspectionIssuesMap< index_t > degenerated_edges{ "degenerated edges" };
         InspectionIssuesMap< index_t > degenerated_polygons{
-            "Section component meshes with degenerated polygons"
+            "degenerated polygons"
         };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/intersections/model_intersections.hpp

@@ -43,7 +43,7 @@ namespace geode
     {
         InspectionIssues<
             std::pair< ComponentMeshElement, ComponentMeshElement > >
-            elements_intersections{ "Surface intersections." };
+            elements_intersections{ "intersections" };
 
         [[nodiscard]] index_t nb_issues() const;
 

include/geode/inspector/criterion/manifold/brep_meshes_manifold.hpp

@@ -58,22 +58,21 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepMeshesManifoldInspectionResult
     {
         InspectionIssuesMap< index_t > meshes_non_manifold_vertices{
-            "BRep component meshes with non manifold vertices"
+            "non manifold mesh vertices"
         };
+
         InspectionIssuesMap< std::array< index_t, 2 > >
-            meshes_non_manifold_edges{
-                "BRep component meshes with non manifold edges"
-            };
+            meshes_non_manifold_edges{ "non manifold mesh edges" };
+
         InspectionIssuesMap< PolyhedronFacetVertices >
-            meshes_non_manifold_facets{
-                "BRep component meshes with non manifold facets"
-            };
+            meshes_non_manifold_facets{ "non manifold mesh facets" };
+
         InspectionIssues< BRepNonManifoldEdge > brep_non_manifold_edges{
-            "BRep non manifold edges"
+            "non manifold model edges"
         };
 
         InspectionIssues< BRepNonManifoldFacet > brep_non_manifold_facets{
-            "BRep non manifold facets"
+            "non manifold model facets"
         };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/manifold/section_meshes_manifold.hpp

@@ -39,12 +39,10 @@ namespace geode
         opengeode_inspector_inspector_api SectionMeshesManifoldInspectionResult
     {
         InspectionIssuesMap< index_t > meshes_non_manifold_vertices{
-            "Section component meshes with non manifold vertices"
+            "non manifold mesh vertices"
         };
         InspectionIssuesMap< std::array< index_t, 2 > >
-            meshes_non_manifold_edges{
-                "Section component meshes with non manifold edges"
-            };
+            meshes_non_manifold_edges{ "non manifold mesh edges" };
 
         [[nodiscard]] index_t nb_issues() const;
 

include/geode/inspector/criterion/negative_elements/brep_meshes_negative_elements.hpp

@@ -42,7 +42,7 @@ namespace geode
         opengeode_inspector_inspector_api BRepMeshesNegativeElementsInspectionResult
     {
         InspectionIssuesMap< index_t > negative_polyhedra{
-            "BRep block meshes with negative polyhedra"
+            "negative polyhedra"
         };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/criterion/negative_elements/section_meshes_negative_elements.hpp

@@ -41,9 +41,7 @@ namespace geode
     struct
         opengeode_inspector_inspector_api SectionMeshesNegativeElementsInspectionResult
     {
-        InspectionIssuesMap< index_t > negative_polygons{
-            "Section surface meshes with negative polygons"
-        };
+        InspectionIssuesMap< index_t > negative_polygons{ "negative polygons" };
 
         [[nodiscard]] index_t nb_issues() const;
 

include/geode/inspector/information.hpp

@@ -72,12 +72,13 @@ namespace geode
         {
             if( issues_.empty() )
             {
-                return absl::StrCat( description_, " -> No Issues :) \n" );
+                return absl::StrCat( "no issues with ", description_, "\n" );
             }
-            auto message = absl::StrCat( description_ );
+            auto message =
+                absl::StrCat( issues_.size(), " issues with ", description_ );
             for( const auto& issue : messages_ )
             {
-                absl::StrAppend( &message, "\n ->    ", issue );
+                absl::StrAppend( &message, "\n\t", issue );
             }
             absl::StrAppend( &message, "\n" );
             return message;
@@ -137,12 +138,13 @@ namespace geode
         {
             if( issues_map_.empty() )
             {
-                return absl::StrCat( description_, " -> No Issues :) \n" );
+                return absl::StrCat( "no issues with ", description_, "\n" );
             }
-            auto message = absl::StrCat( description_ );
+            auto message = absl::StrCat(
+                issues_map_.size(), " issues with ", description_ );
             for( const auto& issues : issues_map_ )
             {
-                absl::StrAppend( &message, "\n ->  ", issues.second.string() );
+                absl::StrAppend( &message, "\n\t", issues.second.string() );
             }
             absl::StrAppend( &message, "\n" );
             return message;

include/geode/inspector/topology/brep_blocks_topology.hpp

@@ -46,44 +46,42 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepBlocksTopologyInspectionResult
     {
         InspectionIssues< uuid > some_blocks_not_meshed{
-            "uuids of Blocks without mesh."
+            "Blocks without mesh (uuid listed)"
         };
         InspectionIssues< uuid > wrong_block_boundary_surface{
-            "uuids of surfaces boundary to a block when they should not."
+            "Surfaces incorrectly bounding Blocks (uuids listed)"
         };
         InspectionIssuesMap< index_t > blocks_not_linked_to_a_unique_vertex{
-            "Blocks with mesh vertices not linked to a unique vertex"
+            "Blocks containing mesh vertices not linked to unique vertices"
         };
         InspectionIssues< index_t >
             unique_vertices_part_of_two_blocks_and_no_boundary_surface{
-                "Indices of unique vertices part of two Blocks and no boundary "
-                "Surface (or Block incident Line)"
+                "unique vertices shared by two Blocks without a boundary "
+                "Surface or incident Block Line"
             };
         InspectionIssues< index_t >
             unique_vertices_with_incorrect_block_cmvs_count{
-                "Indices of unique vertices part of a Block but with incorrect "
-                "ComponentMeshVertices count"
+                "unique vertices in a Block with incorrect Component mesh "
+                "vertices count"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_surface_with_wrong_relationship_to_blocks{
-                "Indices of unique vertices linked to Surface without boundary "
-                "nor internal status."
+                "unique vertices linked to Surfaces with neither boundary nor "
+                "internal status"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_single_and_invalid_surface{
-                "Indices of unique vertices linked to only one Surface and "
-                "this single surface is invalid."
+                "unique vertices linked to a single Surface that is invalid"
             };
         InspectionIssues< uuid > blocks_with_not_closed_boundary_surfaces{
-            "uuids of blocks with not closed boundary surfaces."
+            "Blocks with non-closed boundary Surfaces"
         };
         InspectionIssues< index_t > model_boundaries_dont_form_a_closed_surface{
-            " Model boundaries don't form a closed surface."
+            "model boundaries don't form a closed Surface (uuids listed)"
         };
         InspectionIssues< index_t >
             unique_vertex_linked_to_multiple_invalid_surfaces{
-                "Indices of unique vertices linked to several Surfaces in an "
-                "invalid way."
+                "unique vertices linked to multiple Surfaces in an invalid way"
             };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/topology/brep_corners_topology.hpp

@@ -43,23 +43,23 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepCornersTopologyInspectionResult
     {
         InspectionIssues< uuid > corners_not_meshed{
-            "uuids of Corners without mesh."
+            "Corners without mesh (uuids listed)"
         };
         InspectionIssuesMap< index_t > corners_not_linked_to_a_unique_vertex{
-            "Corners with mesh vertices not linked to a unique vertex"
+            "Corners containing mesh vertices not linked to unique vertices"
         };
         InspectionIssues< index_t > unique_vertices_linked_to_multiple_corners{
-            "Indices of unique vertices that are part of several Corners."
+            "unique vertices shared by several Corners"
         };
         InspectionIssues< index_t >
             unique_vertices_linked_to_not_internal_nor_boundary_corner{
-                "Indices of unique vertices linked to a Corner without "
-                "boundary nor internal status."
+                "unique vertices linked to a Corner with neither "
+                "boundary nor internal status"
             };
         InspectionIssues< index_t >
             unique_vertices_liked_to_not_boundary_line_corner{
-                "Indices of unique vertices linked to a Corner on a line but "
-                "without boundary status."
+                "unique vertices linked to a Line's Corner without boundary "
+                "status"
             };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/topology/brep_lines_topology.hpp

@@ -43,34 +43,32 @@ namespace geode
     struct opengeode_inspector_inspector_api BRepLinesTopologyInspectionResult
     {
         InspectionIssues< uuid > lines_not_meshed{
-            "uuids of Lines without mesh."
+            "Lines without mesh (uuids listed)"
         };
         InspectionIssues< index_t >
             unique_vertices_linked_to_line_with_wrong_relationship_to_surface{
-                "Indices of unique vertices linked to a Line with wrong "
-                "relationship with a surface"
+                "unique vertices linked to a Line with an incorrect "
+                "relationship to a Surface"
             };
         InspectionIssuesMap< index_t > lines_not_linked_to_a_unique_vertex{
             "Lines with mesh vertices not linked to a unique vertex"
         };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_line_with_invalid_embeddings{
-                "Indices of unique vertices linked to a Line with invalid "
-                "internal topology."
+                "unique vertices linked to a Line with invalid internal "
+                "topology"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_single_and_invalid_line{
-                "Indices of unique vertices linked to only one Line and this "
-                "single Line is invalid."
+                "unique vertices linked to a single invalid Line"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_several_lines_but_not_linked_to_a_corner{
-                "Indices of unique vertices linked to several Lines but not "
-                "linked to a Corner."
+                "unique vertices linked to multiple Lines but not to a Corner"
             };
         InspectionIssuesMap< index_t >
             line_edges_with_wrong_component_edges_around{
-                "Indices of line edges with wrong component edges around"
+                "Line edges with incorrect surrounding component edges"
             };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/topology/brep_surfaces_topology.hpp

@@ -42,29 +42,27 @@ namespace geode
         opengeode_inspector_inspector_api BRepSurfacesTopologyInspectionResult
     {
         InspectionIssues< uuid > surfaces_not_meshed{
-            "uuids of surface without mesh."
+            "Surface without mesh (uuids listed)"
         };
         InspectionIssuesMap< index_t > surfaces_not_linked_to_a_unique_vertex{
-            "Surfaces with mesh vertices not linked to a unique vertex"
+            "Surfaces containing mesh vertices not linked to unique vertices"
         };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_surface_with_invalid_embbedings{
-                "Indices of unique vertices linked to a Surface with invalid "
-                "internal topology."
+                "unique vertices linked to a Surface with invalid "
+                "internal topology"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_several_and_invalid_surfaces{
-                "Indices of unique vertices linked to several Surfaces in an "
-                "invalid way."
+                "unique vertices improperly linked to several Surfaces"
             };
         InspectionIssues< index_t >
             unique_vertices_linked_to_a_line_but_is_not_on_a_surface_border{
-                "Indices of unique vertices linked to a Line but not linked to "
-                "a Surface border."
+                "unique vertices linked to a Line but not to a Surface border"
             };
         InspectionIssuesMap< index_t >
             surface_polygons_with_wrong_component_facets_around{
-                "Indices of surface polygons with wrong component facets around"
+                "Surface polygons with invalid surrounding facets"
             };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/topology/brep_topology.hpp

@@ -46,15 +46,15 @@ namespace geode
         BRepSurfacesTopologyInspectionResult surfaces;
         BRepBlocksTopologyInspectionResult blocks;
         InspectionIssues< index_t > unique_vertices_not_linked_to_any_component{
-            "Unique vertices not linked to any component"
+            "unique vertices not linked to a Component"
         };
         InspectionIssues< index_t > unique_vertices_linked_to_inexistant_cmv{
-            "Unique vertices linked to inexistant ComponentMeshVertex"
+            "unique vertices linked to inexistant Component mesh vertex"
         };
         InspectionIssues< index_t >
             unique_vertices_nonbijectively_linked_to_cmv{
-                "Unique vertices with links to ComponentMeshVertex that are "
-                "not bijective"
+                "unique vertices with non-bijective links to "
+                "Component mesh vertex"
             };
 
         [[nodiscard]] index_t nb_issues() const;

include/geode/inspector/topology/internal/topology_helpers.hpp

@@ -100,9 +100,9 @@ namespace geode
                     vertex_id };
                 if( model.unique_vertex( component_mesh_vertex ) == NO_ID )
                 {
-                    result.add_issue( vertex_id,
-                        absl::StrCat( "Vertex '", vertex_id,
-                            "' is not linked to a unique vertex." ) );
+                    result.add_issue(
+                        vertex_id, absl::StrCat( "vertex '", vertex_id,
+                                       " is not linked to a unique vertex." ) );
                 }
             }
             return result;