fix(ErrorMessage): add component name in log message #158
+277
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisbonneau
commented
Oct 28, 2025
panquez
reviewed
Oct 29, 2025
There was a problem hiding this comment.
Comments about forms and homogeneity of messages. I leave @MelchiorSchuh giving its opinion on changes
src/geode/inspector/criterion/adjacency/brep_meshes_adjacency.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/criterion/adjacency/brep_meshes_adjacency.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/criterion/colocation/component_meshes_colocation.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/criterion/internal/component_meshes_degeneration.cpp
Outdated
Show resolved
Hide resolved
| absl::StrCat( "Polygons ", polygon_pair.first.element_id, | ||
| " of surface ", | ||
| absl::StrCat( surface1.name(), " and ", surface2.name(), | ||
| " intersect each other on polygons ", |
There was a problem hiding this comment.
pas sure de comprendre
| { | ||
| InspectionIssues< index_t > wrong_polyhedra{ | ||
| "Negative Polyhedra." | ||
| "Negative Volume Polyhedra" |
There was a problem hiding this comment.
why "volume" (capital letter?) is added here and not on line 47 of file src/geode/inspector/criterion/negative_elements/brep_meshes_negative_elements.cpp
There was a problem hiding this comment.
je penssais qu on ne testeatait pas que le volume sur la brep si?
| { | ||
| InspectionIssues< index_t > wrong_polygons{ "Negative Polygons." }; | ||
| InspectionIssues< index_t > wrong_polygons{ | ||
| "Negative Area Polygons" |
There was a problem hiding this comment.
General comments:
- I prefer uuids of components given directly after name rather than at line end
- each line should be informative on its own, if there are 200 lines of polygon adjacency issues, having to go up the stack to know what the issue is about is a problem
- Fix a convention for upper cases at the beginning of issue strings and apply it everywhere. I would upper-case Corner, Line, Surface, Block and lower case the rest.
| { | ||
| InspectionIssues< PolygonEdge > polygon_edges_with_wrong_adjacency{ | ||
| "Adjacencies between polygon edges not tested" | ||
| "Adjacencies between polygon and edges not tested" |
There was a problem hiding this comment.
revert change, the test is on polygon edges (PolygonEdge)
src/geode/inspector/criterion/intersections/model_intersections.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/criterion/intersections/surface_curve_intersections.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/criterion/intersections/surface_intersections.cpp
Outdated
Show resolved
Hide resolved
src/geode/inspector/criterion/manifold/solid_facet_manifold.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.