Skip to content
Open
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ namespace geode
{
InspectionIssuesMap< PolygonEdge >
surfaces_edges_with_wrong_adjacencies{
"BRep Surface mesh with polygon edges adjacencies issues"
"surface polygon edges adjacencies issues"
};
InspectionIssuesMap< PolyhedronFacet >
blocks_facets_with_wrong_adjacencies{
"BRep Block mesh with polyhedron facets adjacencies issues"
"block polyhedron facets adjacencies issues"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace geode
{
InspectionIssuesMap< PolygonEdge >
surfaces_edges_with_wrong_adjacencies{
"Section Surface mesh polygon edges adjacencies issues"
"surface polygon edges adjacencies issues"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace geode
struct opengeode_inspector_inspector_api MeshesColocationInspectionResult
{
InspectionIssuesMap< std::vector< index_t > > colocated_points_groups{
"Model component meshes with colocated points"
"meshes with colocated points"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,9 @@ namespace geode
struct opengeode_inspector_inspector_api UniqueVerticesInspectionResult
{
InspectionIssues< std::vector< index_t > >
colocated_unique_vertices_groups{
"Model unique vertices which are colocated"
};
colocated_unique_vertices_groups{ "colocated unique vertices" };
InspectionIssues< index_t > unique_vertices_linked_to_different_points{
"Model unique vertices linked to component mesh vertices at "
"different positions"
"unique vertices linked to several positions"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ namespace geode
opengeode_inspector_inspector_api BRepMeshesDegenerationInspectionResult
{
InspectionIssuesMap< index_t > degenerated_edges{
"BRep component meshes with degenerated edges"
"meshes with degenerated edges"
};
InspectionIssuesMap< index_t > degenerated_polygons{
"BRep component meshes with degenerated polygons"
"meshes with degenerated polygons"
};
InspectionIssuesMap< index_t > degenerated_polyhedra{
"BRep component meshes with degenerated polyhedra"
"meshes with degenerated polyhedra"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ namespace geode
opengeode_inspector_inspector_api SectionMeshesDegenerationInspectionResult
{
InspectionIssuesMap< index_t > degenerated_edges{
"Section component meshes with degenerated edges"
"meshes with degenerated edges"
};
InspectionIssuesMap< index_t > degenerated_polygons{
"Section component meshes with degenerated polygons"
"meshes with degenerated polygons"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace geode
{
InspectionIssues<
std::pair< ComponentMeshElement, ComponentMeshElement > >
elements_intersections{ "Surface intersections." };
elements_intersections{ "surface intersections" };

[[nodiscard]] index_t nb_issues() const;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,22 +58,18 @@ namespace geode
struct opengeode_inspector_inspector_api BRepMeshesManifoldInspectionResult
{
InspectionIssuesMap< index_t > meshes_non_manifold_vertices{
"BRep component meshes with non manifold vertices"
"meshes with non manifold vertices"
};
InspectionIssuesMap< std::array< index_t, 2 > >
meshes_non_manifold_edges{
"BRep component meshes with non manifold edges"
};
meshes_non_manifold_edges{ "meshes with non manifold edges" };
InspectionIssuesMap< PolyhedronFacetVertices >
meshes_non_manifold_facets{
"BRep component meshes with non manifold facets"
};
meshes_non_manifold_facets{ "meshes with non manifold facets" };
InspectionIssues< BRepNonManifoldEdge > brep_non_manifold_edges{
"BRep non manifold edges"
"non manifold edges"
};

InspectionIssues< BRepNonManifoldFacet > brep_non_manifold_facets{
"BRep non manifold facets"
"non manifold facets"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,10 @@ namespace geode
opengeode_inspector_inspector_api SectionMeshesManifoldInspectionResult
{
InspectionIssuesMap< index_t > meshes_non_manifold_vertices{
"Section component meshes with non manifold vertices"
"meshes with non manifold vertices"
};
InspectionIssuesMap< std::array< index_t, 2 > >
meshes_non_manifold_edges{
"Section component meshes with non manifold edges"
};
meshes_non_manifold_edges{ "meshes with non manifold edges" };

[[nodiscard]] index_t nb_issues() const;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace geode
opengeode_inspector_inspector_api BRepMeshesNegativeElementsInspectionResult
{
InspectionIssuesMap< index_t > negative_polyhedra{
"BRep block meshes with negative polyhedra"
"block with negative polyhedra"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace geode
opengeode_inspector_inspector_api SectionMeshesNegativeElementsInspectionResult
{
InspectionIssuesMap< index_t > negative_polygons{
"Section surface meshes with negative polygons"
"surface with negative polygons"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
2 changes: 1 addition & 1 deletion include/geode/inspector/edgedcurve_inspector.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace geode
struct opengeode_inspector_inspector_api EdgedCurveInspectionResult
{
InspectionIssues< std::vector< index_t > > colocated_points_groups{
"Colocation of vertices not tested"
"Colocalization of vertices not tested"
};
InspectionIssues< index_t > degenerated_edges{
"Degeneration of edges not tested"
Expand Down
14 changes: 8 additions & 6 deletions include/geode/inspector/information.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,13 @@ namespace geode
{
if( issues_.empty() )
{
return absl::StrCat( description_, " -> No Issues :) \n" );
return absl::StrCat( "No issues with ", description_, "\n" );
}
auto message = absl::StrCat( description_ );
auto message =
absl::StrCat( issues_.size(), " issues with ", description_ );
for( const auto& issue : messages_ )
{
absl::StrAppend( &message, "\n -> ", issue );
absl::StrAppend( &message, "\n\t", issue );
}
absl::StrAppend( &message, "\n" );
return message;
Expand Down Expand Up @@ -137,12 +138,13 @@ namespace geode
{
if( issues_map_.empty() )
{
return absl::StrCat( description_, " -> No Issues :) \n" );
return absl::StrCat( "No issues with ", description_, "\n" );
}
auto message = absl::StrCat( description_ );
auto message = absl::StrCat(
issues_map_.size(), " issues with ", description_ );
for( const auto& issues : issues_map_ )
{
absl::StrAppend( &message, "\n -> ", issues.second.string() );
absl::StrAppend( &message, "\n\t", issues.second.string() );
}
absl::StrAppend( &message, "\n" );
return message;
Expand Down
2 changes: 1 addition & 1 deletion include/geode/inspector/pointset_inspector.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace geode
struct opengeode_inspector_inspector_api PointSetInspectionResult
{
InspectionIssues< std::vector< index_t > > colocated_points_groups{
"Colocation of vertices not tested"
"Colocalization of vertices not tested"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
2 changes: 1 addition & 1 deletion include/geode/inspector/solid_inspector.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace geode
"Adjacencies of facets not tested"
};
InspectionIssues< std::vector< index_t > > colocated_points_groups{
"Colocation of vertices not tested"
"Colocalization of vertices not tested"
};
InspectionIssues< index_t > degenerated_edges{
"Degeneration of edges not tested"
Expand Down
4 changes: 2 additions & 2 deletions include/geode/inspector/surface_inspector.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ namespace geode
struct opengeode_inspector_inspector_api SurfaceInspectionResult
{
InspectionIssues< PolygonEdge > polygon_edges_with_wrong_adjacency{
"Adjacencies between polygon edges not tested"
"Adjacencies between polygon and edges not tested"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert change, the test is on polygon edges (PolygonEdge)

};
InspectionIssues< std::vector< index_t > > colocated_points_groups{
"Colocation of vertices not tested"
"Colocalization of vertices not tested"
};
InspectionIssues< index_t > degenerated_edges{
"Degeneration of edges not tested"
Expand Down
26 changes: 12 additions & 14 deletions include/geode/inspector/topology/brep_blocks_topology.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,44 +46,42 @@ namespace geode
struct opengeode_inspector_inspector_api BRepBlocksTopologyInspectionResult
{
InspectionIssues< uuid > some_blocks_not_meshed{
"uuids of Blocks without mesh."
"blocks without mesh (uuid listed)"
};
InspectionIssues< uuid > wrong_block_boundary_surface{
"uuids of surfaces boundary to a block when they should not."
"surfaces incorrectly bounding blocks (uuids listed)"
};
InspectionIssuesMap< index_t > blocks_not_linked_to_a_unique_vertex{
"Blocks with mesh vertices not linked to a unique vertex"
"blocks containing mesh vertices not linked to unique vertices"
};
InspectionIssues< index_t >
unique_vertices_part_of_two_blocks_and_no_boundary_surface{
"Indices of unique vertices part of two Blocks and no boundary "
"Surface (or Block incident Line)"
"unique vertices shared by two blocks without a boundary "
"surface or incident block line"
};
InspectionIssues< index_t >
unique_vertices_with_incorrect_block_cmvs_count{
"Indices of unique vertices part of a Block but with incorrect "
"unique vertices in a block with incorrect "
"ComponentMeshVertices count"
};
InspectionIssues< index_t >
unique_vertices_linked_to_surface_with_wrong_relationship_to_blocks{
"Indices of unique vertices linked to Surface without boundary "
"nor internal status."
"unique vertices linked to surfaces with neither boundary nor "
"internal status"
};
InspectionIssues< index_t >
unique_vertices_linked_to_a_single_and_invalid_surface{
"Indices of unique vertices linked to only one Surface and "
"this single surface is invalid."
"unique vertices linked to a single surface that is invalid"
};
InspectionIssues< uuid > blocks_with_not_closed_boundary_surfaces{
"uuids of blocks with not closed boundary surfaces."
"blocks with non-closed boundary surfaces"
};
InspectionIssues< index_t > model_boundaries_dont_form_a_closed_surface{
" Model boundaries don't form a closed surface."
"model boundaries don't form a closed surface (uuids listed)"
};
InspectionIssues< index_t >
unique_vertex_linked_to_multiple_invalid_surfaces{
"Indices of unique vertices linked to several Surfaces in an "
"invalid way."
"unique vertices linked to multiple surfaces in an invalid way"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
14 changes: 7 additions & 7 deletions include/geode/inspector/topology/brep_corners_topology.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,23 +43,23 @@ namespace geode
struct opengeode_inspector_inspector_api BRepCornersTopologyInspectionResult
{
InspectionIssues< uuid > corners_not_meshed{
"uuids of Corners without mesh."
"corners without mesh (uuids listed)"
};
InspectionIssuesMap< index_t > corners_not_linked_to_a_unique_vertex{
"Corners with mesh vertices not linked to a unique vertex"
"corners containing mesh vertices not linked to unique vertices"
};
InspectionIssues< index_t > unique_vertices_linked_to_multiple_corners{
"Indices of unique vertices that are part of several Corners."
"unique vertices shared by several corners"
};
InspectionIssues< index_t >
unique_vertices_linked_to_not_internal_nor_boundary_corner{
"Indices of unique vertices linked to a Corner without "
"boundary nor internal status."
"unique vertices linked to a corner with neither "
"boundary nor internal status"
};
InspectionIssues< index_t >
unique_vertices_liked_to_not_boundary_line_corner{
"Indices of unique vertices linked to a Corner on a line but "
"without boundary status."
"unique vertices linked to a line corner without boundary "
"status"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
20 changes: 9 additions & 11 deletions include/geode/inspector/topology/brep_lines_topology.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,34 +43,32 @@ namespace geode
struct opengeode_inspector_inspector_api BRepLinesTopologyInspectionResult
{
InspectionIssues< uuid > lines_not_meshed{
"uuids of Lines without mesh."
"lines without mesh (uuids listed)"
};
InspectionIssues< index_t >
unique_vertices_linked_to_line_with_wrong_relationship_to_surface{
"Indices of unique vertices linked to a Line with wrong "
"relationship with a surface"
"unique vertices linked to a line with an incorrect "
"relationship to a surface"
};
InspectionIssuesMap< index_t > lines_not_linked_to_a_unique_vertex{
"Lines with mesh vertices not linked to a unique vertex"
"lines with mesh vertices not linked to a unique vertex"
};
InspectionIssues< index_t >
unique_vertices_linked_to_a_line_with_invalid_embeddings{
"Indices of unique vertices linked to a Line with invalid "
"internal topology."
"unique vertices linked to a line with invalid internal "
"topology"
};
InspectionIssues< index_t >
unique_vertices_linked_to_a_single_and_invalid_line{
"Indices of unique vertices linked to only one Line and this "
"single Line is invalid."
"unique vertices linked to a single invalid line"
};
InspectionIssues< index_t >
unique_vertices_linked_to_several_lines_but_not_linked_to_a_corner{
"Indices of unique vertices linked to several Lines but not "
"linked to a Corner."
"unique vertices linked to multiple lines but not to a corner"
};
InspectionIssuesMap< index_t >
line_edges_with_wrong_component_edges_around{
"Indices of line edges with wrong component edges around"
"line edges with incorrect surrounding component edges"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
16 changes: 7 additions & 9 deletions include/geode/inspector/topology/brep_surfaces_topology.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,29 +42,27 @@ namespace geode
opengeode_inspector_inspector_api BRepSurfacesTopologyInspectionResult
{
InspectionIssues< uuid > surfaces_not_meshed{
"uuids of surface without mesh."
"surface without mesh (uuids listed)"
};
InspectionIssuesMap< index_t > surfaces_not_linked_to_a_unique_vertex{
"Surfaces with mesh vertices not linked to a unique vertex"
"surfaces containing mesh vertices not linked to unique vertices"
};
InspectionIssues< index_t >
unique_vertices_linked_to_a_surface_with_invalid_embbedings{
"Indices of unique vertices linked to a Surface with invalid "
"internal topology."
"unique vertices linked to a surface with invalid "
"internal topology"
};
InspectionIssues< index_t >
unique_vertices_linked_to_several_and_invalid_surfaces{
"Indices of unique vertices linked to several Surfaces in an "
"invalid way."
"unique vertices improperly linked to several surfaces"
};
InspectionIssues< index_t >
unique_vertices_linked_to_a_line_but_is_not_on_a_surface_border{
"Indices of unique vertices linked to a Line but not linked to "
"a Surface border."
"unique vertices linked to a line but not to a surface border"
};
InspectionIssuesMap< index_t >
surface_polygons_with_wrong_component_facets_around{
"Indices of surface polygons with wrong component facets around"
"Surface polygons with invalid surrounding facets"
};

[[nodiscard]] index_t nb_issues() const;
Expand Down
Loading
Loading