fix: make _hydrateMembers merge objects instead of overriding them #1397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
requested review from
MartinCupela,
khushal87,
myandrienko,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
Contributor
|
Size Change: 0 B Total Size: 458 kB ℹ️ View Unchanged
|
arnautov-anton
changed the title
arnautov-anton
force-pushed
the
fix/channel-members-hydration
branch
from
04c0406 to
655987d
Compare
arnautov-anton
force-pushed
the
fix/channel-members-hydration
branch
from
72762d4 to
4d1b395
Compare
MartinCupela
approved these changes
Nov 26, 2024
Co-authored-by: MartinCupela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes, What, Why and How?
Fixes: GetStream/stream-chat-react#2538
If the channel has been already established and exists within cache, hydrating channel members from thread response which was queried with limited amount of members (or zero even) will results in members property override, deleting previously known members.