Skip to content

chore: update ESLint, migrate configuration file#2574

Merged
arnautov-anton merged 3 commits intomasterfrom
chore/update-eslint
Jan 31, 2025
Merged

chore: update ESLint, migrate configuration file#2574
arnautov-anton merged 3 commits intomasterfrom
chore/update-eslint

Conversation

@arnautov-anton
Copy link
Contributor

@arnautov-anton arnautov-anton commented Dec 7, 2024

🎯 Goal

Time to UPGRADE and migrate. :)

PR is divided into multiple commits, ESLint changes, Prettier changes and manual changes - we can drop Prettier changes for master merges (so that I don't have to deal with merge conflicts) and merge this PR once our PR backlog is somewhat empty.

Notable Changes

  • changed CI to run on Node@lts/* instead of v16 and v18
  • adjusted bundle-cjs.mjs and getPackageVersion.mjs to use import for package.json instead (with assertion)
  • reduced Prettier print-width to 90 (from 100, default is 80) as some new formattings are just weird
  • omitted eslint-plugin-prettier as Prettier format step is included in CI anyway
  • explicitly installed @testing-library/dom as it's required by our tests and is no longer installed with eslint-plugin-jest-dom
  • noUnusedParameters and noUnusedLocals (tsconfig.json) are now set to false to not fail build steps, developers are still warned through ESLint
  • omitted certain other plugins since those weren't used apparently, compare against these old configs - generated against Attachment.test.js and against Attachment.tsx

@arnautov-anton arnautov-anton requested review from MartinCupela, myandrienko and oliverlaz and removed request for myandrienko and oliverlaz December 7, 2024 17:13
@codecov
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 79.61310% with 137 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (a4d6d83) to head (616e877).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Channel/Channel.tsx 74.75% 25 Missing and 1 partial ⚠️
src/components/Channel/channelState.ts 70.45% 10 Missing and 3 partials ⚠️
...omponents/ChannelList/hooks/useChannelListShape.ts 64.28% 5 Missing ⚠️
src/components/ChannelPreview/utils.tsx 37.50% 5 Missing ⚠️
src/components/Channel/utils.ts 71.42% 4 Missing ⚠️
...mponents/ChannelList/hooks/usePaginatedChannels.ts 20.00% 1 Missing and 3 partials ⚠️
src/components/MediaRecorder/transcode/wav.ts 20.00% 4 Missing ⚠️
src/components/Attachment/attachment-sizing.tsx 40.00% 3 Missing ⚠️
src/components/AutoCompleteTextarea/Textarea.jsx 62.50% 3 Missing ⚠️
...nts/ChannelList/hooks/useChannelUpdatedListener.ts 0.00% 3 Missing ⚠️
... and 45 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2574      +/-   ##
==========================================
- Coverage   81.06%   80.84%   -0.22%     
==========================================
  Files         450      450              
  Lines        9505     9631     +126     
  Branches     2233     2297      +64     
==========================================
+ Hits         7705     7786      +81     
- Misses       1684     1725      +41     
- Partials      116      120       +4     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@oliverlaz oliverlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! Thanks for taking care of this long overdue upgrade!

@arnautov-anton arnautov-anton force-pushed the chore/update-eslint branch 9 times, most recently from d037191 to 82edfc7 Compare January 27, 2025 17:31
@arnautov-anton arnautov-anton marked this pull request as ready for review January 27, 2025 18:53
@arnautov-anton arnautov-anton force-pushed the chore/update-eslint branch 2 times, most recently from 1efe134 to 2b07024 Compare January 29, 2025 08:33
@GetStream GetStream deleted a comment from github-actions bot Jan 29, 2025
@GetStream GetStream deleted a comment from github-actions bot Jan 29, 2025
@arnautov-anton arnautov-anton force-pushed the chore/update-eslint branch 2 times, most recently from 5135cd0 to 81fbb69 Compare January 29, 2025 10:33
@GetStream GetStream deleted a comment from github-actions bot Jan 29, 2025
@GetStream GetStream deleted a comment from github-actions bot Jan 30, 2025
@GetStream GetStream deleted a comment from github-actions bot Jan 30, 2025
@GetStream GetStream deleted a comment from github-actions bot Jan 31, 2025
@arnautov-anton arnautov-anton merged commit e81fc69 into master Jan 31, 2025
7 checks passed
@arnautov-anton arnautov-anton deleted the chore/update-eslint branch January 31, 2025 10:01
@stream-ci-bot
Copy link

πŸŽ‰ This PR is included in version 12.11.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants