Skip to content

Conversation

@liviu-timar
Copy link
Contributor

@liviu-timar liviu-timar commented Nov 21, 2024

🎯 Goal

Change deprecation info for Sounds

🛠 Implementation details

  • Made ctor that accepted resources hidden
  • Removed ScheduledForRemoval
  • Actually removed the deprecated constructor after a second analysis.

Change deprecation info for Sounds
@liviu-timar liviu-timar requested a review from a team as a code owner November 21, 2024 14:56
Copy link
Contributor

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aleksandar-apostolov aleksandar-apostolov enabled auto-merge (squash) November 29, 2024 14:53
@aleksandar-apostolov aleksandar-apostolov merged commit ff6deff into develop Nov 29, 2024
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the change-deprecation-status branch November 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants