Skip to content

Change deprecation status for Sounds #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleksandar-apostolov merged 3 commits into from
Nov 29, 2024
Merged

Change deprecation status for Sounds #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9eb612
Change deprecation level for Sounds
liviu-timar Nov 21, 2024
39c44a0
Actually remove deprecated constructor
liviu-timar Nov 29, 2024
ac32ccf
Merge branch 'develop' into change-deprecation-status
aleksandar-apostolov Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions stream-video-android-core/api/stream-video-android-core.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5080,8 +5080,6 @@ public final class io/getstream/video/android/core/sounds/RingingConfigKt {
}

public final class io/getstream/video/android/core/sounds/Sounds {
public fun <init> (II)V
public synthetic fun <init> (IIILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun <init> (Lio/getstream/video/android/core/sounds/RingingConfig;)V
public final fun component1 ()Lio/getstream/video/android/core/sounds/RingingConfig;
public final fun copy (Lio/getstream/video/android/core/sounds/RingingConfig;)Lio/getstream/video/android/core/sounds/Sounds;
Expand Down
14 changes: 1 addition & 13 deletions ...ideo-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import androidx.annotation.RawRes
import io.getstream.log.StreamLog
import io.getstream.video.android.core.R
import io.getstream.video.android.core.utils.safeCallWithDefault
import org.jetbrains.annotations.ApiStatus

// Interface & API
/**
Expand All @@ -48,18 +47,7 @@ public interface RingingConfig {
replaceWith = ReplaceWith("SoundConfig"),
level = DeprecationLevel.WARNING,
)
public data class Sounds(val ringingConfig: RingingConfig) {
@ApiStatus.ScheduledForRemoval(inVersion = "1.0.18")
@Deprecated(
message = "Deprecated. This Constructor will now return a sound configuration with no sounds. Use constructor with SoundConfig parameter instead.",
replaceWith = ReplaceWith("defaultResourcesRingingConfig(context).toSounds()"),
level = DeprecationLevel.ERROR,
)
constructor(
@RawRes incomingCallSound: Int = R.raw.call_incoming_sound,
@RawRes outgoingCallSound: Int = R.raw.call_outgoing_sound,
) : this(emptyRingingConfig())
}
public data class Sounds(val ringingConfig: RingingConfig)

// Factories
/**
Expand Down