-
Notifications
You must be signed in to change notification settings - Fork 56
[AND-171] Refactor call service config #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aleksandar-apostolov
merged 10 commits into
develop
from
feature/rahullohra/extend-call-service-config
Dec 31, 2024
Merged
[AND-171] Refactor call service config #1263
aleksandar-apostolov
merged 10 commits into
develop
from
feature/rahullohra/extend-call-service-config
Dec 31, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ebaa44 to
0a5afe3
Compare
0a5afe3 to
9e45c80
Compare
8c1311d to
8f9034c
Compare
Refactor CallService configuration
8f9034c to
a0fae30
Compare
…-service-config # Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt
853e6d3 to
b8c503e
Compare
aleksandar-apostolov
approved these changes
Dec 31, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Problem Statement: SDK Users need to re-initialize stream sdk to change/update
call configurationThis PR presents solves this by allowing the users to update
call configurationany time🛠 Implementation details
We introduced a new class
CallServiceConfigRegistryto hold the mapping forcall typewithcall configurationIt exposes the following apis
Registering Configurations:
Retrieving Configurations:
Updating Configurations:
CallServiceConfigRegistryis exposed viaClientStateDeprecated APIs in
CallServiceConfig.ktval callServicePerType: Map<String, Class<*>>CallServiceConfigRegistrycallServiceConfig()DefaultCallConfigurations.defaultlivestreamCallServiceConfig()DefaultCallConfigurations.livestreamlivestreamAudioCallServiceConfig()DefaultCallConfigurations.livestreamAudioCalllivestreamGuestCallServiceConfig()DefaultCallConfigurations.livestreamGuestCallaudioCallServiceConfig()DefaultCallConfigurations.audioCallresolveServiceClass(callId: StreamCallId, config: CallServiceConfig)CallServiceConfigRegistry.get()Deprecated APIs in
StreamVideoBuilder.ktprivate val runForegroundServiceForCalls: BooleancallServiceConfigRegistrycallServiceConfigRegistryinstead.private val callServiceConfig: CallServiceConfig?callServiceConfigRegistrycallServiceConfigRegistryinstead.