Skip to content

Conversation

@rahul-lohra
Copy link
Contributor

@rahul-lohra rahul-lohra commented Jan 13, 2025

🎯 Goal

The PR #1263 introduced an issue where the notification for a ringing call was not being removed after the call was declined.

🛠 Implementation details

In the current fix, we stop the foreground service when a ringing call is declined. Previously, we stopped any service within the removeActiveCall(call) method, which functioned correctly, likely because only one service was running. Now, to stop a service, we identify the specific call associated with the service to be terminated.

Here is the previous version of removeActiveCall

fun removeActiveCall() {
        this._activeCall.value = null
        maybeStopForegroundService()
        removeRingingCall()
    }

Here is current version

fun removeActiveCall() {
        if (this._activeCall.value != null) {
            maybeStopForegroundService(this._activeCall.value!!)
            this._activeCall.value = null
        }
        removeRingingCall()
    }    

🎨 UI Changes

Add relevant screenshots

Before After
img img

Add relevant videos

Before After

🧪 Testing

Explain how this change can be tested (or why it can't be tested)

Provide a patch below if it is necessary for testing

Provide the patch summary here
Provide the patch code here

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

1. Revert the order of invoking setActiveCall()
# Conflicts:
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt
…ng call is declined on either of caller or callee side
@rahul-lohra rahul-lohra self-assigned this Jan 13, 2025
@rahul-lohra rahul-lohra requested a review from a team as a code owner January 13, 2025 07:18
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 10.91 MB 10.91 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.81 MB 5.81 MB 0.00 MB 🟢
stream-video-android-ui-compose 5.79 MB 5.80 MB 0.02 MB 🟢

…ng call is declined on either of caller or callee side
@sonarqubecloud
Copy link

@aleksandar-apostolov aleksandar-apostolov changed the title [AND-241] Bugfix/rahullohra/ringing call reject notification [AND-241] Fixed an issue where the notification for a ringing call was not being removed after the call was declined Jan 13, 2025
@aleksandar-apostolov aleksandar-apostolov merged commit 55e6421 into develop Jan 13, 2025
8 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the bugfix/rahullohra/ringing_call_reject_notification branch January 13, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants