Skip to content

[AND-241] Fixed an issue where the notification for a ringing call was not being removed after the call was declined #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleksandar-apostolov merged 6 commits into from
Jan 13, 2025
Merged

[AND-241] Fixed an issue where the notification for a ringing call was not being removed after the call was declined #1280

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99665c6
Fix default notification handler to send correct call service configu…
rahul-lohra Jan 9, 2025
1022fb2
Fix for showing FG service notification
rahul-lohra Jan 10, 2025
305e624
Merge branch 'develop' into bugfix/rahullohra/ringing_call_notification
rahul-lohra Jan 10, 2025
fd3732a
Fix for removal of incoming/outgoing call notification when the ringi…
rahul-lohra Jan 13, 2025
548c219
Merge branch 'refs/heads/develop' into bugfix/rahullohra/ringing_call…
rahul-lohra Jan 13, 2025
fe6ab21
Fix for removal of incoming/outgoing call notification when the ringi…
rahul-lohra Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/ClientState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,10 @@ class ClientState(private val client: StreamVideo) {
}

fun removeActiveCall() {
if (this._activeCall.value != null) {
maybeStopForegroundService(this._activeCall.value!!)
this._activeCall.value = null
_activeCall.value?.let {
maybeStopForegroundService(it)
}
this._activeCall.value = null
removeRingingCall()
}

Expand All @@ -170,6 +170,9 @@ class ClientState(private val client: StreamVideo) {
}

fun removeRingingCall() {
ringingCall.value?.let {
maybeStopForegroundService(it)
}
_ringingCall.value = null
}

Expand Down
Loading