fix(llc, samples): to run video on windows #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe updates remove the Changes
Sequence Diagram(s)sequenceDiagram
participant BuildScript as CMakeLists.txt
participant Env as Environment
participant FlutterTool as Flutter Backend
BuildScript->>Env: Check FLUTTER_TARGET_PLATFORM
alt Variable is set
BuildScript->>FlutterTool: Use FLUTTER_TARGET_PLATFORM
else Not set
BuildScript->>Env: Set FLUTTER_TARGET_PLATFORM to "windows-x64"
BuildScript->>FlutterTool: Use default "windows-x64"
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (6)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
renefloor
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
dogfooding/linux/flutter/generated_plugin_registrant.cc(0 hunks)dogfooding/linux/flutter/generated_plugins.cmake(0 hunks)dogfooding/windows/flutter/CMakeLists.txt(2 hunks)dogfooding/windows/flutter/generated_plugins.cmake(1 hunks)packages/stream_video/lib/src/webrtc/media/audio_constraints.dart(1 hunks)
💤 Files with no reviewable changes (2)
- dogfooding/linux/flutter/generated_plugins.cmake
- dogfooding/linux/flutter/generated_plugin_registrant.cc
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: build
- GitHub Check: analyze
- GitHub Check: analyze_legacy_version
- GitHub Check: stream_video_flutter
- GitHub Check: stream_video_screen_sharing
- GitHub Check: stream_video_noise_cancellation
- GitHub Check: stream_video_push_notification
- GitHub Check: stream_video
🔇 Additional comments (2)
packages/stream_video/lib/src/webrtc/media/audio_constraints.dart (1)
56-56: LGTM! Type consistency improvement for WebRTC constraints.The change from string
'true'to booleantrueis correct and improves type consistency with WebRTC standards. This aligns with other boolean constraints in the same array and ensures proper WebRTC functionality across platforms.dogfooding/windows/flutter/CMakeLists.txt (1)
13-16: Excellent defensive programming approach.The fallback mechanism for
FLUTTER_TARGET_PLATFORMis well-implemented and improves the robustness of the Windows build configuration. This allows for dynamic platform specification while providing a sensible default.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
=====================================
Coverage 4.83% 4.83%
=====================================
Files 577 577
Lines 38802 38802
=====================================
Hits 1875 1875
Misses 36927 36927 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Brazol
reviewed
Jul 15, 2025
Co-authored-by: Maciej Brażewicz <[email protected]>
Brazol
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Run dogfooding on windows.
Related PR: GetStream/webrtc-flutter#37
🛠 Implementation details
Mostly automated changes, the only real change is in audio_constraints.dart
{'DtlsSrtpKeyAgreement': true},☑️Contributor Checklist
General
☑️Reviewer Checklist
Summary by CodeRabbit
Bug Fixes
Chores