fix: prefer the async apply constraints for flip#1679
Merged
santhoshvai merged 4 commits intomainfrom Feb 11, 2025
Merged
Conversation
oliverlaz
approved these changes
Feb 11, 2025
oliverlaz
added a commit
that referenced
this pull request
May 7, 2025
While optimizing the `camera.flip()` API in #1679, we introduced a regression that led to `camera.flip()` throwing a `NotReadableError` on devices with limited hardware capabilities. Some devices are unable to provide two `MediaStream` instances at the same time. ### 📝 Implementation notes We want to preserve the `camera.flip()` optimizations as they allow significantly faster direction change. We always attempt to perform a fast direction change, but if it fails, we fall back to: `stop()` -> `flip()` -> `start()` flow, which is slower, but it works. 🎫 Ticket: https://linear.app/stream/issue/REACT-367/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the momentary mirror bug seen on iOS