fix: missing adaptive floating dimensions for landscape video #1983
+27
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshvai
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the floating video dimensions calculation to handle both portrait and landscape videos more accurately. The algorithm now bases its size on the shorter container dimension rather than only the container width, and applies different sizing logic depending on the video's aspect ratio.
- Changed base dimension calculation from 23% of container width to 23% of the shorter container dimension
- Added container height validation to the early return condition
- Introduced portrait vs landscape video detection and differentiated sizing logic for each orientation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...native-sdk/src/components/Participant/FloatingParticipantView/useFloatingVideoDimensions.tsx
Show resolved
Hide resolved
greenfrvr
approved these changes
Nov 6, 2025
oliverlaz
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
Follow up to #1969
The current algorithm only handles portrait local video on floating view. Which is default on mobile.
But we can change it to landscape video from web for example.
Landscape video needs more width. And this PR fixes it. Again, based on Android AOSP algorithm here.
Additionally, we use screen dimensions to compute the base dimensions now. Because, say if integrator wants to constrain the CallContent to small view, the floating dimensions can become extremely small. Using screen dimensions make it independent of that. This is consistent with Android PiP mode also.
Ticket: https://linear.app/stream/issue/RN-302