Skip to content

fix: missing adaptive floating dimensions for landscape video #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −19
Open

fix: missing adaptive floating dimensions for landscape video #1983

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ae6baa
fix: adaptive floating dimensions for landscape video
santhoshvai Nov 6, 2025
ec4c8fb
directly use screen dimensions
santhoshvai Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions ...ive-sdk/src/components/Participant/FloatingParticipantView/useFloatingVideoDimensions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,36 @@ export const useFloatingVideoDimensions = (
trackType: VideoTrackType,
) => {
const containerWidth = containerDimensions?.width ?? 0;
const containerHeight = containerDimensions?.height ?? 0;
const { width, height } = useTrackDimensions(participant, trackType);

if (width === 0 || height === 0 || containerWidth === 0) {
if (
width === 0 ||
height === 0 ||
containerWidth === 0 ||
containerHeight === 0
) {
return undefined;
}

const aspectRatio = width / height;

// based on Android AOSP PiP mode default dimensions algorithm
// 23% of the container width
const floatingVideoWidth = containerWidth * 0.23;
// the height is calculated based on the aspect ratio
const floatingVideoHeight = floatingVideoWidth / aspectRatio;
// 23% of the shorter container dimension is the base dimension
const shorterContainerDimension = Math.min(containerWidth, containerHeight);
const baseDimension = shorterContainerDimension * 0.23;

return {
width: floatingVideoWidth,
height: floatingVideoHeight,
};
const aspectRatio = width / height;
const isPortraitVideo = aspectRatio < 1;

// baseDimension is assigned to either height or width based on whether the video is landscape or portrait
if (isPortraitVideo) {
return {
width: baseDimension,
height: baseDimension / aspectRatio,
};
} else {
return {
width: baseDimension * aspectRatio,
height: baseDimension,
};
}
};