fix(dogfood): absolutely position closed captions and speaking while muted RN-303 #1984
+126
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
approved these changes
Nov 6, 2025
santhoshvai
changed the title
# Conflicts: # sample-apps/react-native/dogfood/src/components/CallControlls/MoreActionsButton/AndroidAudioRoutePickerDrawer.tsx # sample-apps/react-native/dogfood/src/components/CallControlls/MoreActionsButton/BottomControlsDrawer.tsx
santhoshvai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
Closed captions and speaking while muted, currently take up space even if they have nothing to render.
This PR aims to move it to using absolute position so that its rendered on top of video. Kind of like subtitles over a movie.
Bottom sheet modals now know the bottom controls height and are rendered above it as expected
The behaviour of speaking while muted (swm) and closed captions (cc) is like subtitle over a movie 👇
📝 Implementation notes
🎫 Ticket: https://linear.app/stream/issue/RN-303