fix: ensure proper set up of server-side preferences for mic and camera #2080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Overview
This code used to be buggy, and when combined with
usePersistedDevicePreferences, it was causing a race condition that caused devices to be enabled/disabled randomly, depending on who reached the critical block first.Besides that,
CameraManagerwas incorrectly checking forSEND_AUDIOinstead ofSEND_VIDEOcapability. This is fixed now, too.📝 Implementation notes
applymethod is now refactored and made easier to understand.usePersistedDevicePreferencesnow sets thedeferServerDefaultsflag that prevents applying server-side defaults, as the user preferences should always take precedence. This hook handles the initial device setup up too, so we aren't losing the default settings.🎫 Ticket: https://linear.app/stream/issue/REACT-737/improve-applying-of-default-device-preferences
📑 Docs: https://github.com/GetStream/docs-content/pull/896