Make plot layers & inner subplot layers consistent#1520
Open
Mattriks wants to merge 1 commit intoGiovineItalia:masterfrom
Open
Make plot layers & inner subplot layers consistent#1520Mattriks wants to merge 1 commit intoGiovineItalia:masterfrom
Mattriks wants to merge 1 commit intoGiovineItalia:masterfrom
Conversation
Member
Author
|
Regression testing showed 1 difference: testscripts/auto_enumerate.jl shows |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
layer.statisticsfield ofplot(layer(...))and the inner layers ofGeom.subplot_grid()consistent (fixes Stats in Geom.subplot_grid #1516)Stat.violinas neededlayer.statisticsfield of the outer layer oflayer(Geom.subplot_grid(layer(...))). Note that this should not necessarily be the same asthe
statisticsfield of the inner layers, which are clearly defined by this PR.E.g. the outer layer of
Geom.subplot_gridcould contain statistics which modify aesthetics such as:xgroupand:ygroup, butno such statistics have been developed yet for Gadfly.
Example
(now
p2shows same behaviour asp1from OP in #1516):p1.statisticsandp2.statisticshave not been deprecated, because they may be useful for developers.