Mark ReadDataLineFuture as #[allow(dead_code)]
#2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ReadDataLineFuture` struct was among the facilities added within `gix-packetline` in 41fdb84 (GitoxideLabs#634), and it looks like it may have been intended to be used eventually. However, it is unused. While it is public in `read::sidebands::async_io` module, the only facility from that module that is exposed through `read::sidebands` is `WithSidebands`: https://github.com/GitoxideLabs/gitoxide/blob/04a18f3a4520dd6f49b5f87fe3782dd1cd1547f2/gix-packetline/src/read/sidebands/mod.rs#L6-L9 This situation appears to be long-standing. However, possibly because it is public in its own directly containing module, it was not detected as dead code by `cargo clippy` until recently. Specifically, this caused the CI `lint` job to fail starting in the recently released Rust 1.89. This can be observed by rerunning the workflow where it had passed before: https://github.com/EliahKagan/gitoxide/actions/runs/16739420509/job/47709197815 (The failure only happens in the `lean-async` run of `cargo clippy` because the containing module is not used at all in the `max`, `small`, and `max-pure` builds.) For now, this commit suppresses the error by adding `#[allow(dead_code)]` to `ReadDataLineFuture`.
This was referenced Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReadDataLineFuturestruct was among the facilities added withingix-packetlinein 41fdb84 (#634), and it looks like it may have been intended to be used eventually. However, it is unused.While it is public in
read::sidebands::async_iomodule, the only facility from that module that is exposed throughread::sidebandsisWithSidebands:gitoxide/gix-packetline/src/read/sidebands/mod.rs
Lines 6 to 9 in 04a18f3
This situation appears to be long-standing. However, possibly because it is public in its own directly containing module, it was not detected as dead code by
cargo clippyuntil recently.Specifically, this caused the CI
lintjob to fail starting in the recently released Rust 1.89. This can be observed by rerunning the workflow where it had passed before:https://github.com/EliahKagan/gitoxide/actions/runs/16739420509/job/47709197815
(The failure only happens in the
lean-asyncrun ofcargo clippybecause the containing module is not used at all in themax,small, andmax-purebuilds.)For now, this PR suppresses the error by adding
#[allow(dead_code)]toReadDataLineFuture.It may be that a different fix is preferable, maybe even removing
ReadDataLineFuturealtogether. I figured this would be a reasonable fix to start with, because currently this fails thelintjob in PRs and feature branches, such as this failure in #2106. The idea here is to unblock progress in other areas, but I don't claim that this should be permanent.