fix: preserve externalTrafficPolicy when syncing services#109
Merged
hamzabouissi merged 2 commits intomainfrom Mar 9, 2026
Merged
fix: preserve externalTrafficPolicy when syncing services#109hamzabouissi merged 2 commits intomainfrom
hamzabouissi merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to preserve the source Service’s externalTrafficPolicy when the webhook syncs/creates its corresponding “internal” Service.
Changes:
- Propagate
spec.externalTrafficPolicyfrom the incoming Service into the generated internalV1ServiceSpec.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hamzabouissi
force-pushed
the
fix/externalservicepolicy
branch
from
92222be to
91f5b38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/orgs/internal-GlueOps/projects/3/views/2?pane=issue&itemId=163383375&issue=internal-GlueOps%7Cissues%7C295