Skip to content

fix: preserve externalTrafficPolicy when syncing services #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamzabouissi merged 2 commits into from
Mar 9, 2026
Merged

fix: preserve externalTrafficPolicy when syncing services #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d11ac36
fix: preserve externalTrafficPolicy when syncing services
venkatamutyala Mar 9, 2026
91f5b38
feat: use replace instead of patch for kubernetes services
hamzabouissi Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions webhook-server/app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def apply_custom_object(group, version, namespace, plural, body):
if e.status == 409:
print(f"{resource_name} already exists. Patching (updating)...")
try:
custom_api.patch_namespaced_custom_object(
custom_api.replace_namespaced_custom_object(
group=group,
version=version,
namespace=namespace,
Expand Down Expand Up @@ -174,6 +174,7 @@ def sync(request: dict):
ports=service_ports,
type="ClusterIP",
external_i_ps=public_ips+private_ips,
external_traffic_policy=service['spec'].get('externalTrafficPolicy'),
ip_family_policy=service['spec'].get('ipFamilyPolicy'),
session_affinity=service['spec'].get('sessionAffinity')
)
Expand All @@ -186,16 +187,16 @@ def sync(request: dict):
print(f"Successfully created internal service {internal_service.metadata.name}")
except ApiException as e:
if e.status == 409:
print(f"Internal service {internal_service.metadata.name} already exists. Patching (updating)...")
print(f"Internal service {internal_service.metadata.name} already exists. Replacing (updating)...")
try:
v1.patch_namespaced_service(
v1.replace_namespaced_service(
name=internal_service.metadata.name,
namespace=service['metadata']['namespace'],
body=internal_service
)
print(f"Successfully updated internal service {internal_service.metadata.name}")
except ApiException as e_patch:
print(f"Failed to patch internal service: {e_patch}")
print(f"Failed to replace internal service: {e_patch}")
else:
print(f"Failed to create internal service: {e}")
raise e
Expand Down