Skip to content

fix(admin-ui): correct Cancel button behavior in Jans Lock page to re…#2369

Merged
duttarnab merged 3 commits intomainfrom
admin-ui-issue-2368
Oct 23, 2025
Merged

fix(admin-ui): correct Cancel button behavior in Jans Lock page to re…#2369
duttarnab merged 3 commits intomainfrom
admin-ui-issue-2368

Conversation

@faisalsiddique4400
Copy link
Contributor

fix(admin-ui): correct Cancel button behavior in Jans Lock page to reset form values properly

📝 Description

The Cancel button in the Jans Lock configuration page was not resetting the form fields to their previous values. This fix ensures that the Cancel button correctly reverts all modified fields to their last saved state, maintaining a consistent user experience across configuration pages.

✅ Expected Behavior

  • Clicking Cancel on the Jans Lock page now resets all unsaved changes to their previous values.
  • The button behavior is now aligned with other configuration pages such as SCIM, SMTP, and SAML.

🔗 Ticket

Closes: #2368

@mo-auto mo-auto added comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Oct 17, 2025
Copy link
Contributor

@duttarnab duttarnab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Token Channels field not getting reset.

@faisalsiddique4400
Copy link
Contributor Author

Token channel field resetting successfully now.

duttarnab
duttarnab previously approved these changes Oct 20, 2025
Signed-off-by: Faisal Siddique <71010439+faisalsiddique4400@users.noreply.github.com>
@sonarqubecloud
Copy link

@duttarnab duttarnab merged commit 2ad72a5 into main Oct 23, 2025
7 checks passed
@duttarnab duttarnab deleted the admin-ui-issue-2368 branch October 23, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect cancel button behaviour in the Jans Lock page.

3 participants