Skip to content

fix(admin-ui): correct Cancel button behavior in Jans Lock page to re… #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duttarnab merged 3 commits into from
Oct 23, 2025
Merged

fix(admin-ui): correct Cancel button behavior in Jans Lock page to re… #2369

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fc8c80
fix(admin-ui): correct Cancel button behavior in Jans Lock page to re…
faisalsiddique4400 Oct 17, 2025
79a84bd
fix(admin-ui): token channel field now resetting successfully
faisalsiddique4400 Oct 20, 2025
c52f855
Merge branch 'main' into admin-ui-issue-2368
faisalsiddique4400 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions admin-ui/plugins/jans-lock/components/JansLockConfiguration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
jansLockConstants,
} from '../helper'
import { JansLockConfigFormValues, PatchOperation } from '../types'
import { trimObjectStrings } from 'Utils/Util'

interface JansLockConfigurationProps {
lockConfig: Record<string, unknown>
Expand Down Expand Up @@ -49,9 +50,16 @@ const JansLockConfiguration: React.FC<JansLockConfigurationProps> = ({ lockConfi
validationSchema,
})

const handleCancel = useCallback(() => {
formik.resetForm()
}, [formik])

const submitForm = useCallback(
(userMessage: string) => {
const patchOperations = createPatchOperations(formik.values, lockConfig)
const trimmedValues = trimObjectStrings(
formik.values as unknown as Record<string, unknown>,
) as unknown as JansLockConfigFormValues
const patchOperations = createPatchOperations(trimmedValues, lockConfig)

toggle()

Expand Down Expand Up @@ -398,7 +406,9 @@ const JansLockConfiguration: React.FC<JansLockConfigurationProps> = ({ lockConfi
<Col>
<GluuCommitFooter
saveHandler={toggle}
hideButtons={{ save: true, back: false }}
hideButtons={{ save: true, back: true }}
extraLabel="Cancel"
extraOnClick={handleCancel}
type="submit"
/>
</Col>
Expand Down
Loading