feat: change admin-ui configuration field from useRemotePolicyStore to cedarlingPolicyStoreRetrievalPoint#2427
Conversation
…o cedarlingPolicyStoreRetrievalPoint Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
📝 WalkthroughWalkthroughThe auiConfiguration.json template file replaces the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
mo-auto
added
comp-flex-linux-setup
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| "auiPolicyStoreUrl": "", | ||
| "auiDefaultPolicyStorePath": "./custom/config/adminUI/policy-store.json", | ||
| "useRemotePolicyStore": false | ||
| "cedarlingPolicyStoreRetrievalPoint": "default" |
There was a problem hiding this comment.
🧩 Analysis chain
Configuration field replacement aligns with PR objectives.
The change correctly replaces the boolean useRemotePolicyStore field with the string-based cedarlingPolicyStoreRetrievalPoint field. The default value "default" appears reasonable as an initial retrieval point identifier.
However, this is a breaking configuration change. Please verify:
- No orphaned references: Confirm that no other configuration files, templates, or documentation still reference the old
useRemotePolicyStorefield name. - Code alignment: Ensure that backend and frontend code has been updated to parse and use the new
cedarlingPolicyStoreRetrievalPointfield instead of the old field. - Migration guidance: If this PR is part of a release affecting existing deployments, confirm that breaking change documentation or migration scripts are in place.
Run the following script to search for remaining references to the old field:
🏁 Script executed:
#!/bin/bash
# Description: Search for remaining references to useRemotePolicyStore in the codebase
# Expected: No results if the field has been completely replaced
rg -i 'useRemotePolicyStore' --type json --type py --type ts --type js -C 3Length of output: 0
---
🏁 Script executed:
```shell
#!/bin/bash
# Broader search for old field name without type restrictions
echo "=== Search for useRemotePolicyStore (no type filter) ==="
rg 'useRemotePolicyStore' -C 2 2>&1 | head -50
echo ""
echo "=== Search for cedarlingPolicyStoreRetrievalPoint ==="
rg 'cedarlingPolicyStoreRetrievalPoint' -C 2 2>&1 | head -50
echo ""
echo "=== Verify config file and surrounding context ==="
cat flex-linux-setup/flex_linux_setup/templates/auiConfiguration.json | sed -n '35,45p'
echo ""
echo "=== Search for files importing/referencing auiConfiguration.json ==="
rg -l 'auiConfiguration' -C 1 2>&1 | head -20
Length of output: 1259
---
🏁 Script executed:
```shell
#!/bin/bash
# Check how the config is used in the main setup files
echo "=== flex_setup.py: Config loading context ==="
grep -n 'auiConfiguration\|cedarling\|policyStore' flex-linux-setup/flex_linux_setup/flex_setup.py -i -C 3 | head -60
echo ""
echo "=== bootstrap.py: Config loading context ==="
grep -n 'auiConfiguration\|cedarling\|policyStore' docker-admin-ui/scripts/bootstrap.py -i -C 3 | head -60
echo ""
echo "=== Search for 'cedarling' or 'PolicyStore' in all code files ==="
rg 'cedarling|PolicyStore' -C 2 --type py --type js --type ts 2>&1 | head -100
Length of output: 10368
---
🏁 Script executed:
```shell
#!/bin/bash
# Check if bootstrap.py needs to handle the new field similar to cedarlingLogType
echo "=== bootstrap.py: Full context around field handling ==="
sed -n '240,270p' docker-admin-ui/scripts/bootstrap.py
echo ""
echo "=== Search for how cedarlingLogType is used after being set ==="
rg 'cedarlingLogType' -C 4 2>&1 | head -80
echo ""
echo "=== Search for any conditional based on policy store retrieval point or similar patterns ==="
rg -i 'retrievalPoint|retrieval.?point' -C 3 2>&1
Length of output: 9749
Add field handler to bootstrap.py and implement frontend integration; field currently unused.
The new cedarlingPolicyStoreRetrievalPoint field is defined in the configuration template but missing critical integration:
-
Missing bootstrap.py handler — Unlike similar field
cedarlingLogType(lines 254–256), no existence check or default value initialization. Existing deployments will not have this field. -
No frontend UI —
cedarlingLogTypehas form binding inadmin-ui/plugins/admin/components/Settings/SettingsPage.jswith change detection. The new field has no UI component for users to edit it. -
No code consumption — The field value is never read or used anywhere in backend or frontend logic.
Add to docker-admin-ui/scripts/bootstrap.py (alongside cedarlingLogType handling):
if "cedarlingPolicyStoreRetrievalPoint" not in old_conf["uiConfig"]:
old_conf["uiConfig"]["cedarlingPolicyStoreRetrievalPoint"] = "default"
should_update = TrueThen implement frontend handling and backend consumption matching the cedarlingLogType pattern.
3 participants
closes #2426
Summary by CodeRabbit