swapping around and to avoid null ptr deref #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #388 by reordering function calls in CreateZone to avoid potential null pointer dereferences.
- Calls addRoomToMemory before SaveRoomTemplate.
- Removes the duplicate addRoomToMemory call after saving the room template.
| return 0, err | ||
| } | ||
|
|
||
| addRoomToMemory(newRoom) |
There was a problem hiding this comment.
The error returned from addRoomToMemory is not being checked, which may obscure potential issues when updating the room cache. Consider capturing and handling this error to ensure robust function behavior.
Suggested change
| addRoomToMemory(newRoom) | |
| if err := addRoomToMemory(newRoom); err != nil { | |
| return 0, fmt.Errorf("failed to add room to memory: %w", err) | |
| } |
Volte6
approved these changes
May 19, 2025
Member
Volte6
left a comment
Volte6
left a comment
There was a problem hiding this comment.
Have not tested but looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing issue #388 by swapping around the
addRoomToMemoryandSaveRoomTemplatefunction calls in theCreateZonefunction.Changes
Provide a bullet point list of noteworthy changes in this Pull Request:
addRoomToMemorybeforeSaveRoomTemplateinCreateZone.