security: restrict content script matches to specific domain in favicon sample #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverdunk
requested changes
Jan 8, 2026
Member
oliverdunk
left a comment
oliverdunk
left a comment
There was a problem hiding this comment.
Hi @RinZ27, there is a README associated with this sample which still contains information about this working across all domains. Can you update that?
Contributor
Author
|
Updated the README to match the new host permissions. It now correctly points to Google pages instead of claiming to work everywhere. |
oliverdunk
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sample.favicon-cscurrently uses<all_urls>for its content script matches.Injecting scripts into every page visited by the user is an over-privileged practice that increases the extension's attack surface unnecessarily. Restricting matches to a specific domain (e.g.,
https://www.google.com/*) demonstrates the Principle of Least Privilege while still effectively showing how the Favicon API works in content scripts.