Skip to content

security: restrict content script matches to specific domain in favicon sample #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverdunk merged 2 commits into from
Jan 8, 2026
Merged

security: restrict content script matches to specific domain in favicon sample #1610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c870ff
security: restrict content script matches to specific domain instead …
RinZ27 Jan 8, 2026
f0f4584
docs: update README to reflect domain restriction
RinZ27 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions functional-samples/sample.favicon-cs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Fetching a favicon in a content script

This example fetches the favicon from www.google.com and inserts it at the top left of every page.
This example fetches the favicon from www.google.com and inserts it at the top left of Google search pages.

Note: This extension does not work on `chrome://extensions`.

Expand All @@ -9,7 +9,7 @@ See [Fetching favicons](https://developer.chrome.com/docs/extensions/mv3/favicon
## Testing the extension

1. Follow the instructions to load an [unpacked extension](https://developer.chrome.com/docs/extensions/mv3/getstarted/development-basics/#load-unpacked).
2. Navigate to [www.example.com](https://www.example.com/).
2. Navigate to [www.google.com](https://www.google.com/).

It should look like this:

Expand Down
6 changes: 3 additions & 3 deletions functional-samples/sample.favicon-cs/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "Favicon API in content scripts",
"version": "1.1",
"description": "Demonstrates fetching the favicon from www.google.com and inserting it at the top left of every page.",
"description": "Demonstrates fetching the favicon from www.google.com and inserting it at the top left of the specified pages.",
"manifest_version": 3,
"content_scripts": [
{
"matches": ["<all_urls>"],
"matches": ["https://www.google.com/*"],
"js": ["content.js"],
"css": ["style.css"]
}
Expand All @@ -14,7 +14,7 @@
"web_accessible_resources": [
{
"resources": ["_favicon/*"],
"matches": ["<all_urls>"],
"matches": ["https://www.google.com/*"],
"use_dynamic_url": true
}
]
Expand Down