Skip to content

fix: Add ON DELETE CASCADE to WebFeatures foreign keys #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcscottiii merged 2 commits into from
Aug 5, 2025
Merged

fix: Add ON DELETE CASCADE to WebFeatures foreign keys #1691

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0fd55
fix: Add ON DELETE CASCADE to WebFeatures foreign keys
jcscottiii Aug 4, 2025
d525d37
add missing name
jcscottiii Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions infra/storage/spanner/migrations/000001.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ CREATE TABLE IF NOT EXISTS WPTRunFeatureMetrics (
BrowserName STRING(64) NOT NULL,
TimeStart TIMESTAMP NOT NULL,
-- End denormalized data.
FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
CONSTRAINT FK_WPTRunFeatureMetricsWebFeatureID FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
FOREIGN KEY (ID) REFERENCES WPTRuns(ID)
) PRIMARY KEY (ID, WebFeatureID)
, INTERLEAVE IN PARENT WPTRuns ON DELETE CASCADE;
Expand Down Expand Up @@ -101,7 +101,7 @@ CREATE TABLE IF NOT EXISTS BrowserFeatureAvailabilities (
BrowserName STRING(64) NOT NULL, -- From BCD not wpt.fyi.
BrowserVersion STRING(8) NOT NULL, -- From BCD not wpt.fyi. Only contains major number.
WebFeatureID STRING(36) NOT NULL, -- From web features table.
FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
CONSTRAINT FK_BrowserFeatureAvailabilitiesWebFeatureID FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
FOREIGN KEY (BrowserName, BrowserVersion) REFERENCES BrowserReleases(BrowserName, BrowserVersion),
) PRIMARY KEY (WebFeatureID, BrowserName);

Expand All @@ -115,7 +115,7 @@ CREATE TABLE IF NOT EXISTS FeatureBaselineStatus (
Status STRING(16),
LowDate TIMESTAMP,
HighDate TIMESTAMP,
FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
CONSTRAINT FK_FeatureBaselineStatusWebFeatureID FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
-- Options come from https://github.com/web-platform-dx/web-features/blob/3d4d066c47c9f07514bf743b3955572a6073ff1e/packages/web-features/README.md?plain=1#L17-L24
CHECK (Status IN ('none', 'low', 'high'))
) PRIMARY KEY (WebFeatureID);
Expand Down
2 changes: 1 addition & 1 deletion infra/storage/spanner/migrations/000003.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
CREATE TABLE IF NOT EXISTS FeatureSpecs (
WebFeatureID STRING(36) NOT NULL,
Links ARRAY<STRING(128)>,
FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
CONSTRAINT FK_FeatureSpecsWebFeatureID FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
) PRIMARY KEY (WebFeatureID);
2 changes: 1 addition & 1 deletion infra/storage/spanner/migrations/000011.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ CREATE TABLE IF NOT EXISTS LatestDailyChromiumHistogramMetrics (
WebFeatureID STRING(36) NOT NULL,
ChromiumHistogramEnumValueID STRING(36) NOT NULL,
Day DATE NOT NULL,
FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
FOREIGN KEY (ChromiumHistogramEnumValueID) REFERENCES ChromiumHistogramEnumValues(ID) ON DELETE CASCADE,
FOREIGN KEY (ChromiumHistogramEnumValueID, Day) REFERENCES DailyChromiumHistogramMetrics(ChromiumHistogramEnumValueID, Day) ON DELETE CASCADE,
) PRIMARY KEY (WebFeatureID, ChromiumHistogramEnumValueID);
Loading