fix: Add ON DELETE CASCADE to WebFeatures foreign keys#1691
Merged
jcscottiii merged 2 commits intomainfrom Aug 5, 2025
Merged
Conversation
Fixes #513 Previously, deleting a record from the WebFeatures table would fail if it was referenced by other tables. This change updates all foreign key constraints that reference WebFeatures(ID) to include ON DELETE CASCADE. This ensures that when a feature is deleted, all its associated data in other tables is automatically removed. The constraints have also been given explicit names to improve schema manageability. An integration test has been added to verify the cascade behavior across all related tables and prevent regressions.
jcscottiii
force-pushed
the
jcscottiii/fk-feature-test
branch
from
b3950f0 to
2b0fd55
Compare
jrobbins
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #513
Previously, deleting a record from the WebFeatures table would fail if it was referenced by other tables.
This change updates all foreign key constraints that reference WebFeatures(ID) to include ON DELETE CASCADE. This ensures that when a feature is deleted, all its associated data in other tables is automatically removed.
The constraints have also been given explicit names to improve schema manageability. An integration test has been added to verify the cascade behavior across all related tables and prevent regressions.
After this PR is merged, I will manually adjust the constraints. The constraints currently have random names across staging and prod.