fix: Resolve moved features and refactor evolution handling#1772
Merged
jcscottiii merged 4 commits intomainfrom Aug 30, 2025
Merged
fix: Resolve moved features and refactor evolution handling#1772jcscottiii merged 4 commits intomainfrom
jcscottiii merged 4 commits intomainfrom
Conversation
The primary changes are:
- The `GetMovedWebFeatureDetailsByOriginalFeatureKey` function has been fixed. It was previously returning the internal database ID of the new feature; it now correctly returns the human-readable feature key, as intended.
- The main feature query has been updated to join against a new `SplitWebFeatures` table. The `GET /v1/features` and `GET /v1/features/{feature_id}` endpoints now include an `evolution` object in the response. This object contains `split_off_info` which lists any features that have been split off from the primary feature.
To support this, the following changes were also made:
- The `openapi.yaml` specification has been updated to include the new `evolution` fields in the `Feature` schema.
- The fake data generation process in `util/cmd/load_fake_data` has been significantly enhanced to create more realistic test data for feature evolution, including scenarios for moved, fully split, and partially split features.
- End-to-end tests and snapshots have been updated to reflect the new data structures and the changes in the underlying test data.start
There needs to be some frontend changes. But that will come in a future PR.
Collaborator
Author
|
Given the comment in web-platform-dx/web-features#3000 (comment), we can actually simplify things. I'm going to make those changes. The data model does not currently have the ability to show that feature has been partially split out. I will update this implementation. |
Currently, v3 cannot let us know if a feature has been partially split out. This commit removes the split out info from the Regular Feature model. See comment: web-platform-dx/web-features#3000 (comment) This allows us to simplify this. We can revisit in v4.
jcscottiii
changed the title
Collaborator
Author
|
I just fixed everything now.
|
jrobbins
approved these changes
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the handling of web feature evolution, fixing a key bug and improving test data for future scenarios.
The main change is a fix to ensure that moved or renamed features are resolved correctly by their human-readable feature key, not an internal database ID.
To streamline this work, the evolution object has been removed from the public API for now. The test data generation, however, has been significantly improved to populate the MovedWebFeatures and SplitWebFeatures tables with realistic data. E2E tests and snapshots have been updated to match.