Create separate flags for enabling/disabling each preview feature in isolation. by saranyaloganathan23 · Pull Request #196 · GoogleCloudDataproc/dataproc-jupyter-plugin

saranyaloganathan23 · 2024-12-02T14:04:28Z

Created flags for enabling/disabling the below features in the plugin

GCS
Dataproc Metastore
BigQuery Dataset Explorer

By default, these features are disabled.

…upyter-plugin-fork into vertex-gcs-disable

dataproc_jupyter_plugin/commons/vertexPlatform.py

dataproc_jupyter_plugin/controllers/vertexPlatform.py

dataproc_jupyter_plugin/handlers.py

dataproc_jupyter_plugin/__init__.py

src/utils/const.ts

src/index.ts

…upyter-plugin-fork into vertex-gcs-disable

src/index.ts

…upyter-plugin-fork into vertex-gcs-disable

dataproc_jupyter_plugin/handlers.py

VictorShiAmazingGrace

Would you please add some meaningful PR descriptions to make it easier for reviewers to get the full context of this change? Thanks.

Done

src/index.ts

saranyaloganathan23 · 2025-01-10T04:16:40Z

Would you please add some meaningful PR descriptions to make it easier for reviewers to get the full context of this change? Thanks.

saranyaloganathan23 · 2025-01-27T17:17:06Z

Would you please add some meaningful PR descriptions to make it easier for reviewers to get the full context of this change? Thanks.

Done

update branch

saranyaloganathan23 added 3 commits November 21, 2024 13:15

Merge branch 'main' of https://github.com/Shubha-accenture/dataproc-j…

b9e4694

…upyter-plugin-fork into vertex-gcs-disable

disbale gcs in vertex platform

a58f8d9

Merge branch 'main' of https://github.com/Shubha-accenture/dataproc-j…

d93b3f9

…upyter-plugin-fork into vertex-gcs-disable

saranyaloganathan23 requested review from harsha-accenture, ojarjur and ywskycn December 2, 2024 14:04

ojarjur requested changes Dec 3, 2024

View reviewed changes

dataproc_jupyter_plugin/commons/vertexPlatform.py Outdated Show resolved Hide resolved

dataproc_jupyter_plugin/controllers/vertexPlatform.py Outdated Show resolved Hide resolved

dataproc_jupyter_plugin/handlers.py Outdated Show resolved Hide resolved

saranyaloganathan23 added 2 commits December 5, 2024 15:53

adding flags for left side panels

70b0dbd

remove print

27523cf

ojarjur reviewed Dec 6, 2024

View reviewed changes

dataproc_jupyter_plugin/__init__.py Show resolved Hide resolved

saranyaloganathan23 added 3 commits December 6, 2024 11:14

reverted init.py

c6a789c

reverted additional lines

8dca900

type change

0c4fe81

saranyaloganathan23 requested a review from ojarjur December 6, 2024 05:50

ojarjur reviewed Dec 11, 2024

View reviewed changes

src/utils/const.ts Show resolved Hide resolved

ojarjur reviewed Dec 11, 2024

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

src/index.ts Outdated Show resolved Hide resolved

src/index.ts Outdated Show resolved Hide resolved

saranyaloganathan23 added 2 commits December 13, 2024 09:55

type conversion

b432e07

Merge branch 'main' of https://github.com/Shubha-accenture/dataproc-j…

7f364fe

…upyter-plugin-fork into vertex-gcs-disable

saranyaloganathan23 requested a review from ojarjur December 13, 2024 04:30

handling boolean values

d7bd327

saranyaloganathan23 added the kokoro:force-run label Dec 13, 2024

kokoro-team removed the kokoro:force-run label Dec 13, 2024

ojarjur reviewed Dec 14, 2024

View reviewed changes

src/index.ts Show resolved Hide resolved

ojarjur reviewed Dec 14, 2024

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

ojarjur reviewed Dec 14, 2024

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

code review fixes

353c71a

saranyaloganathan23 requested a review from ojarjur December 19, 2024 08:08

Merge branch 'main' of https://github.com/Shubha-accenture/dataproc-j…

f763a62

…upyter-plugin-fork into vertex-gcs-disable

saranyaloganathan23 added the kokoro:force-run label Dec 20, 2024

kokoro-team removed the kokoro:force-run label Dec 20, 2024

saranyaloganathan23 added the kokoro:force-run label Dec 20, 2024

kokoro-team removed the kokoro:force-run label Dec 20, 2024

ojarjur approved these changes Jan 8, 2025

View reviewed changes

ojarjur changed the title ~~disabling GCS in vertex platform~~ Create separate flags for enabling/disabling each preview feature in isolation. Jan 8, 2025

ojarjur requested review from VictorShiAmazingGrace and jinnthehuman January 8, 2025 05:29

VictorShiAmazingGrace reviewed Jan 8, 2025

View reviewed changes

dataproc_jupyter_plugin/handlers.py Outdated Show resolved Hide resolved

VictorShiAmazingGrace requested changes Jan 8, 2025

View reviewed changes

changing description for metastore

056bf49

saranyaloganathan23 requested review from VictorShiAmazingGrace and ojarjur January 8, 2025 06:59

jinnthehuman requested changes Jan 8, 2025

View reviewed changes

src/index.ts Show resolved Hide resolved

src/index.ts Outdated Show resolved Hide resolved

src/index.ts Show resolved Hide resolved

add logging and removing console

3541462

saranyaloganathan23 requested a review from jinnthehuman January 9, 2025 16:48

jinnthehuman approved these changes Jan 9, 2025

View reviewed changes

saranyaloganathan23 closed this Jan 10, 2025

saranyaloganathan23 reopened this Jan 10, 2025

saranyaloganathan23 requested a review from jinnthehuman January 10, 2025 05:28

VictorShiAmazingGrace approved these changes Jan 27, 2025

View reviewed changes

Shubha-accenture merged commit e29f775 into GoogleCloudDataproc:main Feb 3, 2025
7 checks passed

Shubha-accenture deleted the vertex-gcs-disable branch September 2, 2025 07:07

aditee-accenture pushed a commit that referenced this pull request Jan 13, 2026

Merge pull request #196 from Shubha-accenture/main

9b013f9

update branch

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create separate flags for enabling/disabling each preview feature in isolation.#196

Create separate flags for enabling/disabling each preview feature in isolation.#196
Shubha-accenture merged 15 commits intoGoogleCloudDataproc:mainfrom
Shubha-accenture:vertex-gcs-disable

saranyaloganathan23 commented Dec 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VictorShiAmazingGrace left a comment •

edited by saranyaloganathan23

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saranyaloganathan23 commented Jan 10, 2025

Uh oh!

saranyaloganathan23 commented Jan 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

saranyaloganathan23 commented Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VictorShiAmazingGrace left a comment • edited by saranyaloganathan23 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saranyaloganathan23 commented Jan 10, 2025

Uh oh!

saranyaloganathan23 commented Jan 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

saranyaloganathan23 commented Dec 2, 2024 •

edited

Loading

VictorShiAmazingGrace left a comment •

edited by saranyaloganathan23

Loading