-
Notifications
You must be signed in to change notification settings - Fork 17
Create separate flags for enabling/disabling each preview feature in isolation. #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Shubha-accenture
merged 15 commits into
GoogleCloudDataproc:main
from
Shubha-accenture:vertex-gcs-disable
Feb 3, 2025
Merged
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b9e4694
Merge branch 'main' of https://github.com/Shubha-accenture/dataproc-j…
saranyaloganathan23 a58f8d9
disbale gcs in vertex platform
saranyaloganathan23 d93b3f9
Merge branch 'main' of https://github.com/Shubha-accenture/dataproc-j…
saranyaloganathan23 70b0dbd
adding flags for left side panels
saranyaloganathan23 27523cf
remove print
saranyaloganathan23 c6a789c
reverted init.py
saranyaloganathan23 8dca900
reverted additional lines
saranyaloganathan23 0c4fe81
type change
saranyaloganathan23 b432e07
type conversion
saranyaloganathan23 7f364fe
Merge branch 'main' of https://github.com/Shubha-accenture/dataproc-j…
saranyaloganathan23 d7bd327
handling boolean values
saranyaloganathan23 353c71a
code review fixes
saranyaloganathan23 f763a62
Merge branch 'main' of https://github.com/Shubha-accenture/dataproc-j…
saranyaloganathan23 056bf49
changing description for metastore
saranyaloganathan23 3541462
add logging and removing console
saranyaloganathan23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubha-accenture marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # dataproc_jupyter_plugin/flag.py | ||
|
|
||
| # This is a simple module to store the verterai flag | ||
| # Initialized with a default value | ||
| VERTEX_PLATFORM_ENABLED = False | ||
|
|
||
|
|
||
| def _parse_vertexai_flag(): | ||
| """ | ||
| Parse the vertexai flag from command-line arguments | ||
|
|
||
| This function will be called during extension loading | ||
| """ | ||
| global VERTEX_PLATFORM_ENABLED | ||
| import sys | ||
|
|
||
| for arg in sys.argv: | ||
| if arg.startswith("--isVertexPlatform="): | ||
| VERTEX_PLATFORM_ENABLED = arg.split("=")[1].lower() == "true" | ||
| break | ||
|
|
||
| return VERTEX_PLATFORM_ENABLED |
Shubha-accenture marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Copyright 2024 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
|
|
||
| import json | ||
| import tornado | ||
| from jupyter_server.base.handlers import APIHandler | ||
| from dataproc_jupyter_plugin.commons.vertexPlatform import _parse_vertexai_flag | ||
|
|
||
| class VertexPlatformController(APIHandler): | ||
| @tornado.web.authenticated | ||
| async def get(self): | ||
| try: | ||
| return self.finish({"enabled": _parse_vertexai_flag()}) | ||
|
|
||
| except Exception as e: | ||
| return self.finish({"error": str(e)}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubha-accenture marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.