Skip to content

add addition label to release label workflow#3263

Merged
derrickaw merged 2 commits intoGoogleCloudPlatform:mainfrom
derrickaw:20260127_addAdditionLabel
Jan 27, 2026
Merged

add addition label to release label workflow#3263
derrickaw merged 2 commits intoGoogleCloudPlatform:mainfrom
derrickaw:20260127_addAdditionLabel

Conversation

@derrickaw
Copy link
Contributor

@derrickaw derrickaw commented Jan 27, 2026

  1. Existing release label workflow considers 5 different labels with one being improvement. To me improvement would be about improving on existing code to make it faster, better logic, etc.
  2. There is another label addition that seems to be geared more to new features and such, so adding that label to the release label check.
  3. Also, making the labels in alphanumeric order.
  4. If reviewer thinks we should not do this, should we just delete the addition label to minimize confusion with the release label workflow? Thanks.

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@derrickaw derrickaw added improvement Making existing code better and removed size/XS labels Jan 27, 2026
@derrickaw derrickaw marked this pull request as ready for review January 27, 2026 13:54
@derrickaw derrickaw requested a review from Abacn January 27, 2026 13:55
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SGTM. "addition" is currently used by Issue. Yeah we can use it to label PRs as well.

cc: @damccorm @aasthabharill @rahulkumar0630
(developers contributed recently) FYI the label addition, and in case you have inputs

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@derrickaw derrickaw merged commit 9a0bbda into GoogleCloudPlatform:main Jan 27, 2026
5 checks passed
@derrickaw derrickaw deleted the 20260127_addAdditionLabel branch January 27, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants