-
Notifications
You must be signed in to change notification settings - Fork 111
chore(deps): update nvidia/cuda docker tag to v13 #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update nvidia/cuda docker tag to v13 #337
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the nvidia/cuda Docker images to a new major version, 13.0.1. My review has identified two critical issues. First, the specified Docker image tags do not appear to be publicly available, which will likely cause the build to fail. Second, the Dockerfile contains a hardcoded version of nv-codec-headers that is probably incompatible with the new CUDA version, which could lead to build or runtime failures for video encoding. Please see the detailed comments in the Dockerfile.
| @@ -1,5 +1,5 @@ | |||
| # --- Build stage --- | |||
| FROM nvidia/cuda:12.1.0-devel-ubuntu22.04 AS builder | |||
| FROM nvidia/cuda:13.0.1-devel-ubuntu22.04 AS builder | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Docker image nvidia/cuda:13.0.1-devel-ubuntu22.04 does not appear to be publicly available on Docker Hub. This will cause the build to fail unless the image exists in a private registry. Please ensure the image tag is correct and available.
Additionally, with a major CUDA version update, the hardcoded nv-codec-headers version on line 18 (n12.1.14.0) is likely incompatible. This version is for NVENC API 12.1. A newer CUDA version will require a corresponding nv-codec-headers version, which should be updated to prevent build or runtime errors.
|
|
||
| # --- Runtime stage --- | ||
| FROM nvidia/cuda:12.1.0-runtime-ubuntu22.04 | ||
| FROM nvidia/cuda:13.0.1-runtime-ubuntu22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
There's identified mismatches trying to update cuda/ffmpeg/nv-codex-headers. Won't merge automated updates for this sample at this time. #311 (comment) |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
12.1.0-runtime-ubuntu22.04->13.0.1-runtime-ubuntu22.0412.1.0-devel-ubuntu22.04->13.0.1-devel-ubuntu22.04Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.