Skip to content

Conversation

@renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
nvidia/cuda final major 12.1.0-runtime-ubuntu22.04 -> 13.0.1-runtime-ubuntu22.04
nvidia/cuda stage major 12.1.0-devel-ubuntu22.04 -> 13.0.1-devel-ubuntu22.04

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested review from a team as code owners October 16, 2025 03:08
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the nvidia/cuda Docker base images used in the jobs-video-encoding/Dockerfile to their latest major version, 13.0.1. This ensures the project leverages the newest features, performance improvements, and security patches provided by the updated CUDA toolkit, maintaining compatibility and optimizing GPU-accelerated operations.

Highlights

  • Docker Image Update: The nvidia/cuda base images for both the devel and runtime stages have been updated from version 12.1.0 to 13.0.1.
  • Major Version Upgrade: This pull request performs a major version upgrade for the CUDA Docker images, moving from CUDA 12 to CUDA 13.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@product-auto-label product-auto-label bot added api: run Issues related to the GoogleCloudPlatform/cloud-run-samples API. samples Issues that are directly related to samples. labels Oct 16, 2025
@dpebot
Copy link
Collaborator

dpebot commented Oct 16, 2025

/gcbrun

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the nvidia/cuda Docker images to a new major version, 13.0.1. My review has identified two critical issues. First, the specified Docker image tags do not appear to be publicly available, which will likely cause the build to fail. Second, the Dockerfile contains a hardcoded version of nv-codec-headers that is probably incompatible with the new CUDA version, which could lead to build or runtime failures for video encoding. Please see the detailed comments in the Dockerfile.

@@ -1,5 +1,5 @@
# --- Build stage ---
FROM nvidia/cuda:12.1.0-devel-ubuntu22.04 AS builder
FROM nvidia/cuda:13.0.1-devel-ubuntu22.04 AS builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Docker image nvidia/cuda:13.0.1-devel-ubuntu22.04 does not appear to be publicly available on Docker Hub. This will cause the build to fail unless the image exists in a private registry. Please ensure the image tag is correct and available.

Additionally, with a major CUDA version update, the hardcoded nv-codec-headers version on line 18 (n12.1.14.0) is likely incompatible. This version is for NVENC API 12.1. A newer CUDA version will require a corresponding nv-codec-headers version, which should be updated to prevent build or runtime errors.


# --- Runtime stage ---
FROM nvidia/cuda:12.1.0-runtime-ubuntu22.04
FROM nvidia/cuda:13.0.1-runtime-ubuntu22.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Docker image nvidia/cuda:13.0.1-runtime-ubuntu22.04 does not appear to be publicly available on Docker Hub. This will cause the image pull to fail during the build process unless it's available in a private registry. Please ensure the tag is correct and the image is accessible.

@glasnt
Copy link
Contributor

glasnt commented Oct 16, 2025

There's identified mismatches trying to update cuda/ffmpeg/nv-codex-headers. Won't merge automated updates for this sample at this time. #311 (comment)

@glasnt glasnt closed this Oct 16, 2025
@forking-renovate
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 13.x releases. But if you manually upgrade to 13.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/nvidia-cuda-13.x branch October 16, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: run Issues related to the GoogleCloudPlatform/cloud-run-samples API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants