-
Notifications
You must be signed in to change notification settings - Fork 111
chore(deps): update nvidia/cuda docker tag to v13 #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
renovate-bot
wants to merge
1
commit into
GoogleCloudPlatform:main
from
renovate-bot:renovate/nvidia-cuda-13.x
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # --- Build stage --- | ||
| FROM nvidia/cuda:12.1.0-devel-ubuntu22.04 AS builder | ||
| FROM nvidia/cuda:13.0.1-devel-ubuntu22.04 AS builder | ||
| ENV DEBIAN_FRONTEND=noninteractive | ||
|
|
||
| ENV DIRPATH=/workspace | ||
|
|
@@ -32,7 +32,7 @@ RUN ./configure \ | |
|
|
||
|
|
||
| # --- Runtime stage --- | ||
| FROM nvidia/cuda:12.1.0-runtime-ubuntu22.04 | ||
| FROM nvidia/cuda:13.0.1-runtime-ubuntu22.04 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| ENV NVIDIA_VISIBLE_DEVICES all | ||
| ENV NVIDIA_DRIVER_CAPABILITIES compute,video,utility | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Docker image
nvidia/cuda:13.0.1-devel-ubuntu22.04does not appear to be publicly available on Docker Hub. This will cause the build to fail unless the image exists in a private registry. Please ensure the image tag is correct and available.Additionally, with a major CUDA version update, the hardcoded
nv-codec-headersversion on line 18 (n12.1.14.0) is likely incompatible. This version is for NVENC API 12.1. A newer CUDA version will require a correspondingnv-codec-headersversion, which should be updated to prevent build or runtime errors.