fix(examples): do not manually set env vars in deployment #653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR aims to fix one issue and apply one finOps best practices:
DB_PORTandDB_HOSTfromdeploymentbecause they are both automatically set by the operatorprivateIP: trueto reduce network billingI also feel the
AuthProxyWorkloadshould apply to a label selector so it could match multiple deployments, instead of a single deployment name. I did not include this change in this PR as it is not relevant to how the CSP works :-)Regards,
Sebastien.