Skip to content

Conversation

@stoupance
Copy link
Contributor

Hello,

This PR aims to fix one issue and apply one finOps best practices:

  • Delete env vars DB_PORT and DB_HOST from deployment because they are both automatically set by the operator
  • Add the privateIP: true to reduce network billing

I also feel the AuthProxyWorkload should apply to a label selector so it could match multiple deployments, instead of a single deployment name. I did not include this change in this PR as it is not relevant to how the CSP works :-)

  workloadSelector:
    kind: Deployment
    selector:
      matchLabels:
        cloud-proxy-sql: "true"

Regards,
Sebastien.

  • Tests pass
  • Appropriate changes to README are included in PR

@stoupance stoupance requested a review from a team as a code owner January 2, 2025 15:48
@jackwotherspoon
Copy link
Collaborator

Thanks for this @stoupance 👏

I will let @hessjcg take a look at this 😄

Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for making the examples more helpful!

@hessjcg hessjcg merged commit 4a2d655 into GoogleCloudPlatform:main Jan 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants