Skip to content

fix(examples): do not manually set env vars in deployment #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hessjcg merged 2 commits into from
Jan 17, 2025
Merged

fix(examples): do not manually set env vars in deployment #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a41f84
fix: unset env var automatically set by operator
stoupance Jan 2, 2025
0b26eda
fix: unset env var automatically set by operator
stoupance Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions docs/examples/deployment-mssql-tcp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ spec:
- connectionString: "my-project:us-central1:instance" # from your Cloud SQL Database instance
portEnvName: "DB_PORT" # Will set an env var named 'DB_PORT' to the database port
hostEnvName: "DB_HOST" # Will set an env var named 'DB_HOST' to the proxy's host, 127.0.0.1
privateIP: true # Optional - Will use the private IP instead of public IP
---
##
# Put the database name, username, and password into a kubernetes secret
Expand Down Expand Up @@ -103,10 +104,6 @@ spec:
- "-c"
- "sleep 10 ; /opt/mssql-tools/bin/sqlcmd -S \"tcp:$DB_HOST,$DB_PORT\" -U $DB_USER -P $DB_PASS -Q \"use $DB_NAME ; select 1 ;\" ; sleep 3600"
env:
- name: DB_HOST
value: "set-by-operator"
- name: DB_PORT
value: "set-by-operator"
- name: DB_USER
valueFrom:
secretKeyRef:
Expand Down
5 changes: 1 addition & 4 deletions docs/examples/deployment-mysql-tcp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ spec:
- connectionString: "my-project:us-central1:instance" # from your Cloud SQL Database instance
portEnvName: "DB_PORT" # Will set an env var named 'DB_PORT' to the database port
hostEnvName: "DB_HOST" # Will set an env var named 'DB_HOST' to the proxy's host, 127.0.0.1
privateIP: true # Optional - Will use the private IP instead of public IP
---
##
# Put the database name, username, and password into a kubernetes secret
Expand Down Expand Up @@ -103,10 +104,6 @@ spec:
- "-c"
- "sleep 10 ; mysql --host=$DB_HOST --port=$DB_PORT --user=$DB_USER --password=$DB_PASS --database=$DB_NAME '--execute=select now() ; sleep 3600"
env:
- name: DB_HOST
value: "set-by-operator"
- name: DB_PORT
value: "set-by-operator"
- name: DB_USER
valueFrom:
secretKeyRef:
Expand Down
5 changes: 1 addition & 4 deletions docs/examples/deployment-postgres-tcp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ spec:
- connectionString: "my-project:us-central1:instance" # from your Cloud SQL Database instance
portEnvName: "DB_PORT" # Will set an env var named 'DB_PORT' to the database port
hostEnvName: "DB_HOST" # Will set an env var named 'DB_HOST' to the proxy's host, 127.0.0.1
privateIP: true # Optional - Will use the private IP instead of public IP
---
##
# Put the database name, username, and password into a kubernetes secret
Expand Down Expand Up @@ -103,10 +104,6 @@ spec:
- "-c"
- "sleep 10 ; psql --host=$DB_HOST --port=$DB_PORT --username=$DB_USER '--command=select 1' --echo-queries --dbname=$DB_NAME ; sleep 3600"
env:
- name: DB_HOST
value: "set-by-operator"
- name: DB_PORT
value: "set-by-operator"
- name: DB_USER
valueFrom:
secretKeyRef:
Expand Down
4 changes: 0 additions & 4 deletions docs/quick-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,6 @@ spec:
env:
- name: PORT
value: "8080"
- name: INSTANCE_HOST
value: "set-by-proxy"
- name: DB_PORT
value: "set-by-proxy"
- name: DB_USER
valueFrom:
secretKeyRef:
Expand Down
Loading