chore: switch to ruff linter #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colinchambachan Let me know if you need myself or @kgala2 to help finish this and get it across the line. We are happy to assist if need be 😄 Thanks a ton for the contributions 👏 |
|
Hey @jackwotherspoon, please let me know if there's any other changes / thoughts you have 😁 |
jackwotherspoon
requested changes
May 6, 2025
There was a problem hiding this comment.
@colinchambachan can you run nox -s format on your PR and commit the changes ruff would make. This will make the lint job happy and green for future builds 👍
|
/gcbrun |
jackwotherspoon
approved these changes
May 6, 2025
jackwotherspoon
merged commit 27f6de3
into
GoogleCloudPlatform:main
11 of 12 checks passed
|
Thanks once again @colinchambachan 👏 ⭐ We really value these open-source contributions 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the linting and formatting process from using flake8, isort, and black to Ruff.
@jackwotherspoon, I currently have the ruleset to the default, as when I enabled other rules ("I" for isort, or E501 for line length), it would catch issues that weren't flagged pre-ruff. We can extend the default ruleset using
extend-select=["E501", "I" ...]under the[tool.ruff]section inpyproject.toml.Happy to get some feedback and update accordingly
Related to #1226