Skip to content

chore: switch to ruff linter #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025
Merged

chore: switch to ruff linter #1289

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b249aa
chore: switch to ruff linter
colinchambachan Apr 19, 2025
8eb5bf4
chore: update isort lint config
colinchambachan Apr 24, 2025
d6028b9
chore: update noxfile comments
colinchambachan May 6, 2025
4196ae2
chore: run Ruff formatter
colinchambachan May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 9 additions & 36 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

import nox

BLACK_VERSION = "black==24.10.0"
ISORT_VERSION = "isort==5.13.2"

LINT_PATHS = ["google", "tests", "noxfile.py"]

Expand All @@ -36,32 +34,16 @@ def lint(session):
"""
session.install("-r", "requirements.txt")
session.install(
"flake8",
"flake8-annotations",
"ruff",
"mypy",
BLACK_VERSION,
ISORT_VERSION,
"twine",
"build",
"importlib_metadata==7.2.1",
)
session.run(
"isort",
"--fss",
"--check-only",
"--diff",
"--profile=black",
"--force-single-line-imports",
"--dont-order-by-type",
"--single-line-exclusions=typing",
"-w=88",
*LINT_PATHS,
)
session.run("black", "--check", "--diff", *LINT_PATHS)
session.run(
"flake8",
"google",
"tests",
"ruff",
"check",
*LINT_PATHS,
)
session.run(
"mypy",
Expand All @@ -75,28 +57,19 @@ def lint(session):
session.run("python", "-m", "build", "--sdist")
session.run("twine", "check", "--strict", "dist/*")


@nox.session()
def format(session):
"""
Run isort to sort imports. Then run black
Run isort to sort imports. Then run black
to format code to uniform standard.
"""
session.install(BLACK_VERSION, ISORT_VERSION)
session.install("ruff")
# Use the --fss option to sort imports using strict alphabetical order.
# See https://pycqa.github.io/isort/docs/configuration/options.html#force-sort-within-sectionss
session.run(
"isort",
"--fss",
"--profile=black",
"--force-single-line-imports",
"--dont-order-by-type",
"--single-line-exclusions=typing",
"-w=88",
*LINT_PATHS,
)
session.run(
"black",
"ruff",
"check",
"--fix",
*LINT_PATHS,
)

Expand Down
12 changes: 12 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,15 @@ exclude = ['docs/*', 'samples/*']

[tool.pytest.ini_options]
asyncio_mode = "auto"

[tool.ruff.lint]
extend-select = ["I"]

[tool.ruff.lint.isort]
force-single-line = true
force-sort-within-sections = true
order-by-type = false
single-line-exclusions = ["typing"]

[tool.ruff.format]
quote-style = "double"
Loading