Update Dockerfile #1545
Merged
Update Dockerfile #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowering base image to python:3.12 to resolve torchvision and Jax runtime dependency
saltysoup
requested review from
a team,
alizaidis and
yoshi-approver
as code owners
iennae
reviewed
Dec 4, 2024
Contributor
iennae
left a comment
iennae
left a comment
There was a problem hiding this comment.
@saltysoup can you reach out and talk to @NimJay about this?
1 task
NimJay
approved these changes
Dec 4, 2024
Collaborator
NimJay
left a comment
NimJay
left a comment
There was a problem hiding this comment.
Thank you, @saltysoup, for catching this.
I tried building the image as-is (on the main branch), and got the following error too:
ERROR: Could not find a version that satisfies the requirement torchvision (from versions: none)
I'll be adding a GitHub Action to test docker building of this image in #1549.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lowering base image to python:3.12 to resolve torchvision and Jax runtime dependency
Description
This PR....
Tasks