Test "docker build" of ai-ml/maxdiffusion-tpu/build/server/ #1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
bourgeoisor
approved these changes
Dec 6, 2024
Member
bourgeoisor
left a comment
bourgeoisor
left a comment
There was a problem hiding this comment.
LGTM, thank you for adding this test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Update Dockerfile #1545, we identified that an image broke because of an update to the Python version used by the image.
Ideally, this breakage would have been caught by our automation (pull-request GitHub Actions).
This change introduces a GitHub Action that tests
docker building of the image.I used this template:
github/new-samples-templates/workflow.ymlHere's an existing example:
/.github/workflows/ai-ml-gke-finetuning-gemma.ymlMerge this pull-request for me once it is approved.