Image error by hao-nan-li · Pull Request #13863 · GoogleCloudPlatform/magic-modules

hao-nan-li · 2025-05-06T17:13:20Z

Fixes hashicorp/terraform-provider-google#22566

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

…e namings

modular-magician · 2025-05-06T17:25:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 48 insertions(+))
google-beta provider: Diff ( 3 files changed, 48 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2025-05-06T19:26:05Z

Tests analytics

Total tests: 4901
Passed tests: 4442
Skipped tests: 456
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccUniverseDomainDiskImage

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician · 2025-05-06T19:31:09Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/third_party/terraform/envvar/envvar_utils.go

mmv1/third_party/terraform/provider/universe/universe_domain_compute_test.go

modular-magician · 2025-05-12T20:28:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 61 insertions(+))
google-beta provider: Diff ( 3 files changed, 61 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2025-05-12T22:33:09Z

Tests analytics

Total tests: 4917
Passed tests: 4457
Skipped tests: 456
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician · 2025-05-12T22:51:46Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

rileykarson

Hmm- the new test isn't running. Do we need to register something somewhere to have its package get picked up?

mmv1/third_party/terraform/provider/universe/universe_domain_compute_test.go

hao-nan-li · 2025-05-13T16:46:23Z

Do we need to register something somewhere to have its package get picked up?

Looks like this test actually passed in https://storage.mtls.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-13863/artifacts/7b3e92a9-bb66-47fb-a694-79ad3ff89ed0/build-log/replaying_test.log. For some reason it didn't show up on the UI

hao-nan-li · 2025-05-14T18:15:23Z

mmv1/third_party/terraform/provider/provider.go.tmpl

 		return nil, diag.FromErr(err)
 	}

+	// Bypass checkDestroyer failure with universe domain set


@c2thorn FYI, this is added to bypass check destroy error

Why does this work exactly? I don't think we're generally expected to call d.Set inside the provider as it's not a full resource, so I'm a bit surprised it even works.

If this works, this is the exact same as removing the check later in https://github.com/hashicorp/terraform-provider-google/blob/main/google/provider/provider.go#L1266. There's no point in having both.

I was hoping to either set the universe domain in a test-only setup function, or skip the check altogether by adding something to

else if config.UniverseDomain != "" && config.UniverseDomain != "googleapis.com"

that verifies if it is a test run.

What is the issue we're seeing exactly? Does https://github.com/hao-nan-li/magic-modules/blob/2b5b82e44b188362545a5ca43a854c7397079d75/mmv1/third_party/terraform/provider/universe/universe_domain_compute_test.go#L145 not have the domain set?

Here's the flow:

https://github.com/hashicorp/terraform-provider-google/blob/main/google/provider/universe/universe_domain_compute_test.go#L100

https://github.com/hashicorp/terraform-provider-google/blob/main/google/acctest/provider_test_utils.go#L45

The configure function then calls https://github.com/hashicorp/terraform-provider-google/blob/ff829fe23a4235e6566fd07be74c52e32e376b69/google/provider/provider.go#L921

Finally an error occurs because universe_domain is not set in d (schema.ResourceData). And the code right below will return an error, then the check destroyer function fails.

Adding this block of code works around this problem

Discussed offline; we can likely set the value on https://github.com/hashicorp/terraform-provider-google/blob/8ef7e5fbcf4f8d5a2a141dfff29bffc52d119e65/google/acctest/provider_test_utils.go#L44 to later successfully call configure.

More broadly, we should figure out how the two initialization paths (through the provider factory and there) are different, and ideally align them.

Applied fix in provider_test_utils. And this solves the error in check destroy.

Will take a look at the second suggestion.

modular-magician · 2025-05-14T18:26:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 13 insertions(+))

hao-nan-li · 2025-05-14T18:49:16Z

the unit test failure looks unrelated to this change, perhaps it's something needed to be fixed...

rileykarson · 2025-05-14T18:54:27Z

FYI @ScottSuarez as this may be related to #13929

In the meantime can you rebase this PR on top of main? That could be a possible trigger.

modular-magician · 2025-05-14T19:09:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 13 insertions(+))

modular-magician · 2025-05-14T19:11:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 13 insertions(+))

modular-magician · 2025-05-14T19:14:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 13 insertions(+))

modular-magician · 2025-05-14T19:16:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 13 insertions(+))

modular-magician · 2025-05-14T20:28:16Z

Tests analytics

Total tests: 4924
Passed tests: 4460
Skipped tests: 458
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician · 2025-05-14T20:48:02Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-14T21:12:15Z

Tests analytics

Total tests: 4924
Passed tests: 4461
Skipped tests: 458
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician · 2025-05-14T21:24:59Z

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-14T21:28:21Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-14T21:29:52Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-14T22:22:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 66 insertions(+))
terraform-google-conversion: Diff ( 3 files changed, 13 insertions(+))

modular-magician · 2025-05-14T23:12:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 65 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 65 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 3 files changed, 6 insertions(+), 1 deletion(-))

modular-magician · 2025-05-15T00:22:53Z

Tests analytics

Total tests: 4934
Passed tests: 4467
Skipped tests: 460
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudIdentityGroup

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician · 2025-05-15T01:15:07Z

Tests analytics

Total tests: 4938
Passed tests: 4472
Skipped tests: 460
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudIdentityGroup

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician · 2025-05-15T04:27:23Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-15T05:18:07Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/third_party/terraform/acctest/provider_test_utils.go

rileykarson · 2025-05-15T18:49:20Z

mmv1/third_party/terraform/services/compute/image.go

 		}
 	}
+	if c.UniverseDomain != "" && c.UniverseDomain != "googleapis.com" {
+		resolveImageLink = regexp.MustCompile(fmt.Sprintf("^https://compute.%s/compute/[a-z0-9]+/projects/(%s)/global/images/(%s)", c.UniverseDomain, verify.ProjectRegex, resolveImageImageRegex))


This fix works but we should probably make it more clear. Out of band, could we move resolveImageLink into a function that returns the appropriate link for the current universe? That'll guard against direct access of the raw value, move the logic together, and give a good spot to document the differences with a function comment.

rileykarson · 2025-05-15T18:50:09Z

mmv1/third_party/terraform/envvar/envvar_utils.go

 }

+// Project Prefix of different universes
+func GetProjectPrefixFromEnv() string {


In a followup PR could you change the env var to include "Universe" in the namespace? i.e. GOOGLE_UNIVERSE_PROJECT_PREFIX / GetUniverseProjectPrefixFromEnv

Co-authored-by: Riley Karson <rileykarson@google.com>

modular-magician · 2025-05-15T19:08:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 67 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 67 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 3 files changed, 6 insertions(+), 1 deletion(-))

modular-magician · 2025-05-15T21:10:25Z

Tests analytics

Total tests: 4950
Passed tests: 4483
Skipped tests: 460
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudIdentityGroup

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician · 2025-05-15T21:30:34Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudIdentityGroup [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Co-authored-by: Riley Karson <rileykarson@google.com>

hao-nan-li added 4 commits May 5, 2025 14:11

Fix compute_image issue in universe domains

f3d2962

Fix Lint

443baef

fix lint

0acc4ea

Add GOOGLE_PROJECT_PREFIX env var, modified image test to fit variabl…

5be10e2

…e namings

hao-nan-li marked this pull request as ready for review May 6, 2025 20:34

hao-nan-li requested a review from rileykarson May 6, 2025 20:34

rileykarson reviewed May 8, 2025

View reviewed changes

mmv1/third_party/terraform/envvar/envvar_utils.go Show resolved Hide resolved

mmv1/third_party/terraform/provider/universe/universe_domain_compute_test.go Outdated Show resolved Hide resolved

Fix test so that it could run in multiple universes

59f9274

rileykarson reviewed May 12, 2025

View reviewed changes

mmv1/third_party/terraform/provider/universe/universe_domain_compute_test.go Outdated Show resolved Hide resolved

Fix check destroyer error in different universe domain

b43fb40

hao-nan-li commented May 14, 2025

View reviewed changes

hao-nan-li force-pushed the image_error branch from 3cc8131 to b43fb40 Compare May 14, 2025 19:01

Merge branch 'GoogleCloudPlatform:main' into image_error

2b5b82e

Merge branch 'GoogleCloudPlatform:main' into image_error

45fec1b

Re-work on fixing check destroy

834f5e4

rileykarson approved these changes May 15, 2025

View reviewed changes

Update mmv1/third_party/terraform/acctest/provider_test_utils.go

ee076c4

Co-authored-by: Riley Karson <rileykarson@google.com>

hao-nan-li added this pull request to the merge queue May 15, 2025

Merged via the queue into GoogleCloudPlatform:main with commit 1c17945 May 15, 2025
25 of 26 checks passed

hao-nan-li deleted the image_error branch May 15, 2025 21:48

This was referenced May 15, 2025

Image error hashicorp/terraform-provider-google#22809

Merged

Image error hashicorp/terraform-provider-google-beta#10007

Merged

Image error GoogleCloudPlatform/terraform-google-conversion#3905

Merged

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025

Image error (GoogleCloudPlatform#13863)

c56733a

Co-authored-by: Riley Karson <rileykarson@google.com>

stevenyang72 mentioned this pull request May 22, 2025

Add workload identity pool managed identity. #14048

Merged

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025

Image error (GoogleCloudPlatform#13863)

4586fb2

Co-authored-by: Riley Karson <rileykarson@google.com>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025

Image error (GoogleCloudPlatform#13863)

2b8f317

Co-authored-by: Riley Karson <rileykarson@google.com>

jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025

Image error (GoogleCloudPlatform#13863)

4ed2210

Co-authored-by: Riley Karson <rileykarson@google.com>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Image error (GoogleCloudPlatform#13863)

0905c1a

Co-authored-by: Riley Karson <rileykarson@google.com>

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025

Image error (GoogleCloudPlatform#13863)

ca72604

Co-authored-by: Riley Karson <rileykarson@google.com>

Conversation

hao-nan-li commented May 6, 2025

Uh oh!

modular-magician commented May 6, 2025

Diff report

Uh oh!

modular-magician commented May 6, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

modular-magician commented May 12, 2025

Diff report

Uh oh!

modular-magician commented May 12, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 12, 2025

Uh oh!

rileykarson left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hao-nan-li commented May 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hao-nan-li May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

modular-magician commented May 14, 2025

Diff report

Uh oh!

hao-nan-li commented May 14, 2025

Uh oh!

rileykarson commented May 14, 2025

Uh oh!

modular-magician commented May 14, 2025

Diff report

Uh oh!

modular-magician commented May 14, 2025

Diff report

Uh oh!

modular-magician commented May 14, 2025

Diff report

Uh oh!

modular-magician commented May 14, 2025

Diff report

Uh oh!

modular-magician commented May 14, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 14, 2025

Uh oh!

modular-magician commented May 14, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 14, 2025

Uh oh!

modular-magician commented May 14, 2025

Uh oh!

modular-magician commented May 14, 2025

rileykarson left a comment •

edited

Loading

hao-nan-li May 14, 2025 •

edited

Loading