Skip to content

Conversation

@hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Jan 13, 2025

Description

Migrate region "datacatalog_create_entry_group_tag" to "data_catalog_create_entry_group_tag"

Fixes b/389693076

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners January 13, 2025 18:59
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by @hivanalejandro, aims to fix a bug by migrating a region tag in the nodejs-docs-samples repository. Specifically, it updates the datacatalog/cloud-client/createEntryGroup.js file.

Here's a breakdown of the changes:

  • Intent: Migrate the region tag from datacatalog_create_entry_group_tag to data_catalog_create_entry_group_tag.
  • Changes:
    • The file datacatalog/cloud-client/createEntryGroup.js has been modified.
    • Lines 28-29 were modified to include both data_catalog_create_entry_group_tag and datacatalog_create_entry_group_tag. The original tag was preserved.
    • Line 63 was modified to include both data_catalog_create_entry_group_tag and datacatalog_create_entry_group_tag. The original tag was preserved.
  • Associated Issue: This PR fixes issue b/389693076.

The author has indicated that all tests and linting checks have passed. They've also confirmed adherence to the project's contribution guidelines.


A little haiku to brighten your day:

Tags shift, code refined,
Bugs flee, a smoother system,
Joy in clean commits.

Thanks,
Gemini

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: datacatalog Issues related to the Data Catalog API. labels Jan 13, 2025
@snippet-bot
Copy link

snippet-bot bot commented Jan 13, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The region tag was migrated successfully.

entryGroupId
) => {
// [START data_catalog_create_entry_group_tag]
// [START datacatalog_create_entry_group_tag]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The start region tag data_catalog_create_entry_group_tag is duplicated. Remove the extra tag.

Suggested change
// [START datacatalog_create_entry_group_tag]
// [START data_catalog_create_entry_group_tag]

@iennae iennae merged commit 1a7e648 into main Jan 16, 2025
15 checks passed
@iennae iennae deleted the hivanalejandro-migrate-region-step1-389693076 branch January 16, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datacatalog Issues related to the Data Catalog API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants