Skip to content

fix: (data_catalog) migrate region tag #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iennae merged 3 commits into from
Jan 16, 2025
Merged

fix: (data_catalog) migrate region tag #3946

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cc2d1a
fix: (data_catalog) migrate region tag
hivanalejandro Jan 13, 2025
b65a2ac
fix: (data_catalog) remove bracket spacing
hivanalejandro Jan 13, 2025
4ad38aa
fix: (data_catalog) update region tag in createEntryGroup.js
hivanalejandro Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion datacatalog/cloud-client/createEntryGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,12 @@
projectId = process.env.GOOGLE_CLOUD_PROJECT,
entryGroupId
) => {
// [START data_catalog_create_entry_group_tag]
// [START datacatalog_create_entry_group_tag]
Copy link

@ghost ghost Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The start region tag data_catalog_create_entry_group_tag is duplicated. Remove the extra tag.

Suggested change
// [START datacatalog_create_entry_group_tag]
// [START data_catalog_create_entry_group_tag]

// -------------------------------
// Import required modules.
// -------------------------------
const {DataCatalogClient} = require('@google-cloud/datacatalog').v1;
const { DataCatalogClient } = require('@google-cloud/datacatalog').v1;

Check failure on line 33 in datacatalog/cloud-client/createEntryGroup.js

View workflow job for this annotation

GitHub Actions / lint 

Replace `·DataCatalogClient·` with `DataCatalogClient`
const datacatalog = new DataCatalogClient();

// Currently, Data Catalog stores metadata in the
Expand Down Expand Up @@ -59,6 +60,7 @@

console.log(response);
// [END datacatalog_create_entry_group_tag]
// [END data_catalog_create_entry_group_tag]
};

// node createEntryGroup.js <projectId> <entryGroupId>
Expand Down
Loading