Skip to content

fix(retail): add region tag for JS - search simple query #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rebeccaellis wants to merge 4 commits into from
Closed

fix(retail): add region tag for JS - search simple query #4105

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf9bdd0
Update search-simple-query.js
rebeccaellis Jun 10, 2025
4248f5c
Merge pull request #1 from rebeccaellis/rebeccaellis-patch-1
rebeccaellis Jun 10, 2025
79c293e
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 10, 2025
fd745e2
Update search-simple-query.js
rebeccaellis Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions retail/interactive-tutorials/search/search-simple-query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// [START retail_search_simple_query]

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider removing this blank line. The Samples Style Guide, referenced in the PR checklist, indicates that [START ...] region tags should be placed immediately before the code block they designate1. Examples in the guide do not show an intervening blank line. Removing this line would align the formatting more closely with the documented conventions.

Style Guide References

Footnotes

  1. The Google Samples Style Guide section on Region Tags states to 'Place the [START ...] tag immediately before the code block'. Examples provided throughout the guide consistently show region tags directly adjacent to the code, without extra blank lines. ↩

'use strict';

async function main() {
Expand Down Expand Up @@ -76,3 +78,5 @@ process.on('unhandledRejection', err => {
});

main();

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the [START ...] tag, consider removing this blank line. The Samples Style Guide indicates that [END ...] tags should be placed immediately after the code block1. Examples in the guide do not show a preceding blank line. Removing this line would ensure consistency with the documented conventions.

Style Guide References

Footnotes

  1. The Google Samples Style Guide section on Region Tags states to 'Place the ... [END ...] tag immediately after [the code block]'. Examples provided throughout the guide consistently show region tags directly adjacent to the code, without extra blank lines. ↩

// [END retail_search_simple_query]