-
Notifications
You must be signed in to change notification settings - Fork 66
fix(deps): update dependency axios to v1.12.0 [security] #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate-bot
wants to merge
1
commit into
GoogleCloudPlatform:main
Choose a base branch
from
renovate-bot:renovate/npm-axios-vulnerability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(deps): update dependency axios to v1.12.0 [security] #828
renovate-bot
wants to merge
1
commit into
GoogleCloudPlatform:main
from
renovate-bot:renovate/npm-axios-vulnerability
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/gcbrun |
aabmass
approved these changes
Sep 30, 2025
Contributor
|
/gcbrun |
auto-merge was automatically disabled
October 1, 2025 23:10
Head branch was pushed to by a user without write access
3ee8c5b to
bd3921b
Compare
Collaborator
|
/gcbrun |
bd3921b to
660b09a
Compare
Collaborator
|
/gcbrun |
660b09a to
1941172
Compare
Collaborator
|
/gcbrun |
1941172 to
7363593
Compare
Collaborator
|
/gcbrun |
7363593 to
96e3958
Compare
Collaborator
|
/gcbrun |
96e3958 to
28851f1
Compare
Collaborator
|
/gcbrun |
28851f1 to
8eba82b
Compare
Collaborator
|
/gcbrun |
8eba82b to
7eb71c8
Compare
Collaborator
|
/gcbrun |
7eb71c8 to
6c44518
Compare
Collaborator
|
/gcbrun |
6c44518 to
ea8faf9
Compare
Collaborator
|
/gcbrun |
ea8faf9 to
e02af34
Compare
Collaborator
|
/gcbrun |
e02af34 to
e671244
Compare
Collaborator
|
/gcbrun |
e671244 to
a21e8fe
Compare
Collaborator
|
/gcbrun |
a21e8fe to
a2dcca0
Compare
Collaborator
|
/gcbrun |
a2dcca0 to
2d3f897
Compare
Collaborator
|
/gcbrun |
2d3f897 to
fe158c8
Compare
Collaborator
|
/gcbrun |
fe158c8 to
4d1fddb
Compare
Collaborator
|
/gcbrun |
4d1fddb to
dbede8e
Compare
Collaborator
|
/gcbrun |
dbede8e to
554209b
Compare
Collaborator
|
/gcbrun |
554209b to
49b3037
Compare
Collaborator
|
/gcbrun |
49b3037 to
5ab5591
Compare
Collaborator
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.11.0->1.12.0GitHub Vulnerability Alerts
CVE-2025-58754
Summary
When Axios runs on Node.js and is given a URL with the
data:scheme, it does not perform HTTP. Instead, its Node http adapter decodes the entire payload into memory (Buffer/Blob) and returns a synthetic 200 response.This path ignores
maxContentLength/maxBodyLength(which only protect HTTP responses), so an attacker can supply a very largedata:URI and cause the process to allocate unbounded memory and crash (DoS), even if the caller requestedresponseType: 'stream'.Details
The Node adapter (
lib/adapters/http.js) supports thedata:scheme. Whenaxiosencounters a request whose URL starts withdata:, it does not perform an HTTP request. Instead, it callsfromDataURI()to decode the Base64 payload into a Buffer or Blob.Relevant code from
[httpAdapter](https://redirect.github.com/axios/axios/blob/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b/lib/adapters/http.js#L231):The decoder is in
[lib/helpers/fromDataURI.js](https://redirect.github.com/axios/axios/blob/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b/lib/helpers/fromDataURI.js#L27):config.maxContentLengthorconfig.maxBodyLength, which only apply to HTTP streams.data:URI of arbitrary size can cause the Node process to allocate the entire content into memory.In comparison, normal HTTP responses are monitored for size, the HTTP adapter accumulates the response into a buffer and will reject when
totalResponseBytesexceeds[maxContentLength](https://redirect.github.com/axios/axios/blob/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b/lib/adapters/http.js#L550). No such check occurs fordata:URIs.PoC
Run with limited heap to force a crash:
Since Node heap is capped at 100 MB, the process terminates with an out-of-memory error:
Mini Real App PoC:
A small link-preview service that uses axios streaming, keep-alive agents, timeouts, and a JSON body. It allows data: URLs which axios fully ignore
maxContentLength,maxBodyLengthand decodes into memory on Node before streaming enabling DoS.Run this app and send 3 post requests:
Suggestions
Enforce size limits
For
protocol === 'data:', inspect the length of the Base64 payload before decoding. Ifconfig.maxContentLengthorconfig.maxBodyLengthis set, reject URIs whose payload exceeds the limit.Stream decoding
Instead of decoding the entire payload in one
Buffer.fromcall, decode the Base64 string in chunks using a streaming Base64 decoder. This would allow the application to process the data incrementally and abort if it grows too large.Release Notes
axios/axios (axios)
v1.12.0Compare Source
Bug Fixes
Features
Contributors to this release
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.