test(secretmanager): add test_create_secret_without_ttl

[eapl-gemugami]

Description

Fixes Internal: b/404625519

Checklist

• I have followed Sample Guidelines from AUTHORING_GUIDE.MD
• Tests pass: nox -s py-3.9 (see Test Environment Setup)
• Lint pass: nox -s lint (see Test Environment Setup)
• Please merge this PR for me once it is approved

[gemini-code-assist]

Hello @eapl-gemugami, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds a new test case, test_create_secret_without_ttl, to the secretmanager/snippets/snippets_test.py file. This test verifies the behavior of the create_secret function when no time-to-live (TTL) value is provided. The existing test_create_secret function is also updated to assert that the secret has an expiration time when a TTL is provided. The PR addresses the internal issue b/404625519.

Highlights

• New Test Case: A new test case, test_create_secret_without_ttl, is added to verify the creation of secrets without a TTL.
• Assertion Update: The existing test_create_secret function is updated to assert that the secret has an expiration time when a TTL is provided.

Changelog

• secretmanager/snippets/snippets_test.py
  • Added test_create_secret_without_ttl to verify secret creation without TTL.
  • Updated test_create_secret to assert the existence of an expiration time when TTL is provided.
  • The new test case asserts that secret.expire_time is None when no TTL is specified (lines 245-252).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A secret's born, with or without,
A time to live, beyond all doubt.
With TTL set, its fate is sealed,
Without, its life, yet to be revealed.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request adds a new test case test_create_secret_without_ttl to verify the behavior of the create_secret function when no TTL is provided. This is a good addition to ensure that secrets can be created without a TTL and that the expire_time attribute is correctly handled in such cases. The code is generally clear and well-structured.

Merge Readiness

The code changes are well-structured and the new test case provides valuable coverage for the create_secret function. I recommend merging this pull request. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.