Skip to content

test(secretmanager): add test_create_secret_without_ttl #13243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025
Merged

test(secretmanager): add test_create_secret_without_ttl #13243

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ce3e2d
test(secretmanager): add test test_create_secret_without_ttl
eapl-gemugami Mar 18, 2025
ec5dc4c
test(secretmanager): make a simple change to trigger GitHub Actions a…
eapl-gemugami Mar 24, 2025
c4f8d7c
test(secretmanager): revert previous commit
eapl-gemugami Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion secretmanager/snippets/snippets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,13 +232,24 @@ def test_add_secret_version(secret: Tuple[str, str, str]) -> None:


def test_create_secret(
client: secretmanager.SecretManagerServiceClient,
project_id: str,
secret_id: str,
ttl: Optional[str],
) -> None:
secret = create_secret(project_id, secret_id, ttl)

assert secret_id in secret.name
assert secret.expire_time


def test_create_secret_without_ttl(
project_id: str,
secret_id: str,
) -> None:
secret = create_secret(project_id, secret_id, None)

assert secret_id in secret.name
assert not secret.expire_time


def test_create_secret_with_user_managed_replication(
Expand Down