Bumping node archives to latest stable versions#1830
Conversation
Signed-off-by: Distroless Bot <distroless-bot@google.com>
There was a problem hiding this comment.
Summary of Changes
Hello @distroless-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request automates the process of keeping Node.js archives up-to-date by bumping the versions of Node.js 22 and 24 to their latest stable releases. It involves updating the source definitions, their corresponding checksums, and relevant test data, ensuring the project consistently uses the most recent and secure Node.js distributions.
Highlights
- Node.js Version Updates: Updated Node.js 22 from
v22.17.1tov22.18.0and Node.js 24 fromv24.4.1tov24.5.0. - Checksum and URL Updates: Refreshed SHA256 checksums and download URLs for all supported architectures (amd64, arm64, arm, ppc64le, s390x) for both Node.js 22 and 24 archives.
- Test Configuration Alignment: Adjusted test configurations to reflect the new expected Node.js versions, ensuring test suites validate against the updated binaries.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| name = "nodejs22_amd64", | ||
| sha256 = "cfb6ac0cf339825fe36efd1f18a79016b02aca19fbfa6c9547c57e27dc09f6ea", | ||
| strip_prefix = "node-v22.17.1-linux-x64/", | ||
| urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-x64.tar.gz"], | ||
| version = "22.17.1", | ||
| sha256 = "a2e703725d8683be86bb5da967bf8272f4518bdaf10f21389e2b2c9eaeae8c8a", | ||
| strip_prefix = "node-v22.18.0-linux-x64/", | ||
| urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-x64.tar.gz"], | ||
| version = "22.18.0", | ||
| architecture = "amd64", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs22_arm64", | ||
| sha256 = "f53510706998cf044f634190416f0588e7e1937aecea938768952e0f0ac1f41b", | ||
| strip_prefix = "node-v22.17.1-linux-arm64/", | ||
| urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-arm64.tar.gz"], | ||
| version = "22.17.1", | ||
| sha256 = "d415eeea90a2fdb60c66dd386b258acbfc4d1fa4720a8df5dea7369fbdbcddee", | ||
| strip_prefix = "node-v22.18.0-linux-arm64/", | ||
| urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-arm64.tar.gz"], | ||
| version = "22.18.0", | ||
| architecture = "arm64", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs22_arm", | ||
| sha256 = "520dcd113eca345074cab3c3e7c23b93517a6a0a22fac98e843b195fcfdcc5d7", | ||
| strip_prefix = "node-v22.17.1-linux-armv7l/", | ||
| urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-armv7l.tar.gz"], | ||
| version = "22.17.1", | ||
| sha256 = "57830914581dc3640e8d95378b76c6910860f42531959e4e88eb445e0cd982b0", | ||
| strip_prefix = "node-v22.18.0-linux-armv7l/", | ||
| urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-armv7l.tar.gz"], | ||
| version = "22.18.0", | ||
| architecture = "arm", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs22_ppc64le", | ||
| sha256 = "c07ee9fb0c0396f5551a9c0228570fdb45ebf21ba9723f7098671320f364a202", | ||
| strip_prefix = "node-v22.17.1-linux-ppc64le/", | ||
| urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-ppc64le.tar.gz"], | ||
| version = "22.17.1", | ||
| sha256 = "38f965cbaa5e730dbd3b1afe895cfdb86da96371474827d05d847d338a0c9c97", | ||
| strip_prefix = "node-v22.18.0-linux-ppc64le/", | ||
| urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-ppc64le.tar.gz"], | ||
| version = "22.18.0", | ||
| architecture = "ppc64le", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs22_s390x", | ||
| sha256 = "5ee94f6e421a383435c2f96b8e5742ad0eea54a851dc6b66583fc28a2f84cd33", | ||
| strip_prefix = "node-v22.17.1-linux-s390x/", | ||
| urls = ["https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-s390x.tar.gz"], | ||
| version = "22.17.1", | ||
| sha256 = "f3578b0e7cdf247045f6eeb766febd74942954352161102cb6040a4d4c3b4c3c", | ||
| strip_prefix = "node-v22.18.0-linux-s390x/", | ||
| urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-s390x.tar.gz"], | ||
| version = "22.18.0", | ||
| architecture = "s390x", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_amd64", | ||
| sha256 = "063f2eb299ba60e3fc9b424d8e87d0e2f6be84b39bdeadc421ee2865914c498b", | ||
| strip_prefix = "node-v24.4.1-linux-x64/", | ||
| urls = ["https://nodejs.org/dist/v24.4.1/node-v24.4.1-linux-x64.tar.gz"], | ||
| version = "24.4.1", | ||
| sha256 = "369f2a3668dde7e324697040fafdcf442fd198b8c102317145417b3c83a9794a", | ||
| strip_prefix = "node-v24.5.0-linux-x64/", | ||
| urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-x64.tar.gz"], | ||
| version = "24.5.0", | ||
| architecture = "amd64", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_arm64", | ||
| sha256 = "fde5421e2652e51199bc678e1e6c4d80bbb4c55337ec0a82206568517e9792ef", | ||
| strip_prefix = "node-v24.4.1-linux-arm64/", | ||
| urls = ["https://nodejs.org/dist/v24.4.1/node-v24.4.1-linux-arm64.tar.gz"], | ||
| version = "24.4.1", | ||
| sha256 = "c643c118d907c8db42a677a12789eb5d55ad6de4b8e2c11bab08dbd23852da2e", | ||
| strip_prefix = "node-v24.5.0-linux-arm64/", | ||
| urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-arm64.tar.gz"], | ||
| version = "24.5.0", | ||
| architecture = "arm64", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_ppc64le", | ||
| sha256 = "b4ee745e4d8a2c3f3a793a50695d769322b81c79f2b7b79c2a359bca892a0f36", | ||
| strip_prefix = "node-v24.4.1-linux-ppc64le/", | ||
| urls = ["https://nodejs.org/dist/v24.4.1/node-v24.4.1-linux-ppc64le.tar.gz"], | ||
| version = "24.4.1", | ||
| sha256 = "7f45e28aedae5a4077c04fa1934268c9e3620dcfb105624517c2410ca1deb00d", | ||
| strip_prefix = "node-v24.5.0-linux-ppc64le/", | ||
| urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-ppc64le.tar.gz"], | ||
| version = "24.5.0", | ||
| architecture = "ppc64le", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_s390x", | ||
| sha256 = "8c9a680c3ae7c8b4a02f55faa055d960ab639a67b257efe7a466d49934746630", | ||
| strip_prefix = "node-v24.4.1-linux-s390x/", | ||
| urls = ["https://nodejs.org/dist/v24.4.1/node-v24.4.1-linux-s390x.tar.gz"], | ||
| version = "24.4.1", | ||
| sha256 = "1d151244f5502ff7e72271e603889d789dec021f0cb28148d90f4a8ce89eaf30", | ||
| strip_prefix = "node-v24.5.0-linux-s390x/", | ||
| urls = ["https://nodejs.org/dist/v24.5.0/node-v24.5.0-linux-s390x.tar.gz"], | ||
| version = "24.5.0", | ||
| architecture = "s390x", | ||
| control = "//nodejs:control", |
There was a problem hiding this comment.
The node_archive definitions are highly repetitive. Consider refactoring to use a data structure and a loop to generate these definitions. This would improve maintainability, especially when updating to new Node.js versions. For example, create a dictionary mapping versions to their corresponding architectures and checksums, then iterate through this dictionary to generate the node_archive calls.
|
🌳 🔄 Image Check This pull request has modified the following images: //nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs22_root_arm64_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs22_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs22_root_s390x_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs22_nonroot_s390x_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//nodejs:nodejs22_nonroot_arm_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs22_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs22_root_s390x_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs22_nonroot_arm_debian12You can check the details in the report here |
Signed-off-by: Distroless Bot distroless-bot@google.com